From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC9E5C54EBD for ; Mon, 9 Jan 2023 22:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235396AbjAIWYg (ORCPT ); Mon, 9 Jan 2023 17:24:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237072AbjAIWYd (ORCPT ); Mon, 9 Jan 2023 17:24:33 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A373FE0AC; Mon, 9 Jan 2023 14:24:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54F2CB81071; Mon, 9 Jan 2023 22:24:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4325C433EF; Mon, 9 Jan 2023 22:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673303070; bh=qMWCtVxblvUkiS1rIu7bKNT+hakIcHnEGsYK4truBKI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kYnmE+wV3X2vGCWoJyR5GoG6wgUssHZ1GM6pDrVzOSQaRwK/bBNTQgDcCFBxt71Yc JdNvSiVGLPp2NhTJLuraDd0PoPZeHihY4Ddiw+5akWSTSjz+kkkFPWBLooEpybo3+v dNHrkht0uveyowdQdLInmLsOOuSkDv/PECeUK019ys0Bia1u/ily4Veb0Xg5d0scSp cZ0mAZCtJOaTsSeZVwTtIfpEGJZYV+PC0BMNFhXZZ0DtpBjpooX3Kcko2TAaVpYAdW 11N9IOEySBYzrvOpUmrh/9xkY7UsxDSJleNIU/5qW1aa71zUzUCfB15Iecz1MyI332 mRVYcgG0nwtfw== Date: Mon, 9 Jan 2023 14:24:28 -0800 From: Saeed Mahameed To: Leon Romanovsky Cc: Jason Gunthorpe , Or Har-Toov , "David S. Miller" , Eric Dumazet , Jakub Kicinski , linux-rdma@vger.kernel.org, Michael Guralnik , netdev@vger.kernel.org, Paolo Abeni , Saeed Mahameed Subject: Re: [PATCH rdma-next 4/4] RDMA/mlx5: Use query_special_contexts for mkeys Message-ID: References: <4c58f1aa2e9664b90ecdc478aef12213816cf1b7.1672819469.git.leonro@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 08 Jan 12:21, Leon Romanovsky wrote: >On Thu, Jan 05, 2023 at 05:04:03PM -0800, Saeed Mahameed wrote: >> On 04 Jan 16:03, Leon Romanovsky wrote: >> > On Wed, Jan 04, 2023 at 09:56:21AM -0400, Jason Gunthorpe wrote: >> > > On Wed, Jan 04, 2023 at 03:55:25PM +0200, Leon Romanovsky wrote: >> > > > On Wed, Jan 04, 2023 at 09:13:10AM -0400, Jason Gunthorpe wrote: >> > > > > On Wed, Jan 04, 2023 at 03:09:54PM +0200, Leon Romanovsky wrote: >> > > > > > On Wed, Jan 04, 2023 at 09:03:06AM -0400, Jason Gunthorpe wrote: >> > > > > > > On Wed, Jan 04, 2023 at 10:11:25AM +0200, Leon Romanovsky wrote: >> > > > > > > > -int mlx5_cmd_null_mkey(struct mlx5_core_dev *dev, u32 *null_mkey) >> > > > > > > > -{ >> > > > > > > > - u32 out[MLX5_ST_SZ_DW(query_special_contexts_out)] = {}; >> > > > > > > > - u32 in[MLX5_ST_SZ_DW(query_special_contexts_in)] = {}; >> > > > > > > > - int err; >> > > > > > > > + err = mlx5_cmd_exec_inout(dev->mdev, query_special_contexts, in, out); >> > > > > > > > + if (err) >> > > > > > > > + return err; >> > > > > > > > >> > > > > > > > - MLX5_SET(query_special_contexts_in, in, opcode, >> > > > > > > > - MLX5_CMD_OP_QUERY_SPECIAL_CONTEXTS); >> > > > > > > > - err = mlx5_cmd_exec_inout(dev, query_special_contexts, in, out); >> > > > > > > > - if (!err) >> > > > > > > > - *null_mkey = MLX5_GET(query_special_contexts_out, out, >> > > > > > > > - null_mkey); >> > > > > > > > - return err; >> > > > > > > > + if (MLX5_CAP_GEN(dev->mdev, dump_fill_mkey)) >> > > > > > > > + dev->mkeys.dump_fill_mkey = MLX5_GET(query_special_contexts_out, >> > > > > > > > + out, dump_fill_mkey); >> > > > > > > > + >> > > > > > > > + if (MLX5_CAP_GEN(dev->mdev, null_mkey)) >> > > > > > > > + dev->mkeys.null_mkey = cpu_to_be32( >> > > > > > > > + MLX5_GET(query_special_contexts_out, out, null_mkey)); >> > > > > > > > + >> > > > > > > > + if (MLX5_CAP_GEN(dev->mdev, terminate_scatter_list_mkey)) { >> > > > > > > > + dev->mkeys.terminate_scatter_list_mkey = >> > > > > > > > + cpu_to_be32(MLX5_GET(query_special_contexts_out, out, >> > > > > > > > + terminate_scatter_list_mkey)); >> > > > > > > > + return 0; >> > > > > > > > + } >> > > > > > > > + dev->mkeys.terminate_scatter_list_mkey = >> > > > > > > > + MLX5_TERMINATE_SCATTER_LIST_LKEY; >> > > > > > > >> > > > > > > This is already stored in the core dev, why are you recalculating it >> > > > > > > here? >> > > > > > >> > > > > > It is not recalculating but setting default value. In core dev, we will >> > > > > > have value only if MLX5_CAP_GEN(dev->mdev, terminate_scatter_list_mkey) >> > > > > > is true. >> > > > > >> > > > > No, it has the identical code: >> > > > > >> > > > > +static int mlx5_get_terminate_scatter_list_mkey(struct mlx5_core_dev *dev) >> > > > > +{ >> > > > > + if (MLX5_CAP_GEN(dev, terminate_scatter_list_mkey)) { >> > > > > + dev->terminate_scatter_list_mkey = >> > > > > + cpu_to_be32(MLX5_GET(query_special_contexts_out, out, >> > > > > + terminate_scatter_list_mkey)); >> > > > > + return 0; >> > > > > + } >> > > > > + dev->terminate_scatter_list_mkey = MLX5_TERMINATE_SCATTER_LIST_LKEY; >> > > > >> > > > Ahh, you are talking about that. >> > > > terminate_scatter_list_mkey is part of an output from MLX5_CMD_OP_QUERY_SPECIAL_CONTEXTS, >> > > > which is needed to get other mkeys. So instead of doing special logic >> > > > for the terminate_scatter_list_mkey, we decided to use same pattern as >> > > > for other mkeys, which don't belong to core. >> > > >> > > Regardless, don't duplicate the code and maybe don't even duplicate >> > > the storage of the terminate_scatter_list_mkey >> > >> > ok, will update and resend. >> > >> >> Please provide a helper mlx5_get_xyz function, avoid assuming mlx5_core will store >> it in dev->xyz. > >This helper was used in this version of patch and it is: > MLX5_GET(query_special_contexts_out, out, terminate_scatter_list_mkey)) >Which was dropped in favor of Jason's request to rely on mlx5_core_dev >as this value already known: >https://lore.kernel.org/all/cover.1672917578.git.leonro@nvidia.com > >I don't like the idea to add obfuscation function just for the sake of >obfuscation. If you don't want access to mlx5_core_dev, please argue with >Jason to accept first variant. I think you are confused, 1st version duplicated the logic that already existed in mlx5 core, didn't just access with MLX5_GET.