From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Davide Caratti <dcaratti@redhat.com>
Cc: jhs@mojatatu.com, jiri@resnulli.us, lucien.xin@gmail.com,
netdev@vger.kernel.org, pabeni@redhat.com, wizhao@redhat.com,
xiyou.wangcong@gmail.com
Subject: Re: [PATCH net-next 1/2] net/sched: act_mirred: better wording on protection against excessive stack growth
Date: Mon, 23 Jan 2023 14:22:32 -0300 [thread overview]
Message-ID: <Y87CWGgHk8f0EWfA@t14s.localdomain> (raw)
In-Reply-To: <a59d4d9295e40fe6cfaa0803c5a7cc6e80e7b1a2.1674233458.git.dcaratti@redhat.com>
On Fri, Jan 20, 2023 at 06:01:39PM +0100, Davide Caratti wrote:
> with commit e2ca070f89ec ("net: sched: protect against stack overflow in
> TC act_mirred"), act_mirred protected itself against excessive stack growth
> using per_cpu counter of nested calls to tcf_mirred_act(), and capping it
> to MIRRED_RECURSION_LIMIT. However, such protection does not detect
> recursion/loops in case the packet is enqueued to the backlog (for example,
> when the mirred target device has RPS or skb timestamping enabled). Change
> the wording from "recursion" to "nesting" to make it more clear to readers.
>
> CC: Jamal Hadi Salim <jhs@mojatatu.com>
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
next prev parent reply other threads:[~2023-01-23 17:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 17:01 [PATCH net-next 0/2] net/sched: use the backlog for nested mirred ingress Davide Caratti
2023-01-20 17:01 ` [PATCH net-next 1/2] net/sched: act_mirred: better wording on protection against excessive stack growth Davide Caratti
2023-01-23 17:22 ` Marcelo Ricardo Leitner [this message]
2023-01-23 19:40 ` Jamal Hadi Salim
2023-01-20 17:01 ` [PATCH net-next 2/2] act_mirred: use the backlog for nested calls to mirred ingress Davide Caratti
2023-01-23 17:22 ` Marcelo Ricardo Leitner
2023-01-23 19:41 ` Jamal Hadi Salim
2023-12-04 20:24 ` Mirred broken WAS(Re: " Jamal Hadi Salim
2023-12-05 10:54 ` Davide Caratti
2023-12-05 15:12 ` Jamal Hadi Salim
2023-12-07 14:10 ` Jamal Hadi Salim
2023-12-11 13:07 ` Davide Caratti
2023-12-11 15:50 ` Jamal Hadi Salim
2023-01-24 9:40 ` [PATCH net-next 0/2] net/sched: use the backlog for nested " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y87CWGgHk8f0EWfA@t14s.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=dcaratti@redhat.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wizhao@redhat.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox