* [net] net: ethernet: adi: adin1110: Fix multicast offloading
@ 2023-01-20 9:08 Alexandru Tachici
2023-01-24 1:45 ` Andrew Lunn
2023-01-24 5:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Alexandru Tachici @ 2023-01-20 9:08 UTC (permalink / raw)
To: linux-kernel; +Cc: davem, edumazet, kuba, pabeni, netdev, yangyingliang
Driver marked broadcast/multicast frames as offloaded incorrectly.
Mark them as offloaded only when HW offloading has been enabled.
This should happen only for ADIN2111 when both ports are bridged
by the software.
Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
drivers/net/ethernet/adi/adin1110.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/adi/adin1110.c b/drivers/net/ethernet/adi/adin1110.c
index 0805f249fff2..c26b8597945b 100644
--- a/drivers/net/ethernet/adi/adin1110.c
+++ b/drivers/net/ethernet/adi/adin1110.c
@@ -356,7 +356,7 @@ static int adin1110_read_fifo(struct adin1110_port_priv *port_priv)
if ((port_priv->flags & IFF_ALLMULTI && rxb->pkt_type == PACKET_MULTICAST) ||
(port_priv->flags & IFF_BROADCAST && rxb->pkt_type == PACKET_BROADCAST))
- rxb->offload_fwd_mark = 1;
+ rxb->offload_fwd_mark = port_priv->priv->forwarding;
netif_rx(rxb);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [net] net: ethernet: adi: adin1110: Fix multicast offloading
2023-01-20 9:08 [net] net: ethernet: adi: adin1110: Fix multicast offloading Alexandru Tachici
@ 2023-01-24 1:45 ` Andrew Lunn
2023-01-24 5:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2023-01-24 1:45 UTC (permalink / raw)
To: Alexandru Tachici
Cc: linux-kernel, davem, edumazet, kuba, pabeni, netdev,
yangyingliang
On Fri, Jan 20, 2023 at 11:08:46AM +0200, Alexandru Tachici wrote:
> Driver marked broadcast/multicast frames as offloaded incorrectly.
> Mark them as offloaded only when HW offloading has been enabled.
> This should happen only for ADIN2111 when both ports are bridged
> by the software.
>
> Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
> Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [net] net: ethernet: adi: adin1110: Fix multicast offloading
2023-01-20 9:08 [net] net: ethernet: adi: adin1110: Fix multicast offloading Alexandru Tachici
2023-01-24 1:45 ` Andrew Lunn
@ 2023-01-24 5:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-01-24 5:50 UTC (permalink / raw)
To: Alexandru Tachici
Cc: linux-kernel, davem, edumazet, kuba, pabeni, netdev,
yangyingliang
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 20 Jan 2023 11:08:46 +0200 you wrote:
> Driver marked broadcast/multicast frames as offloaded incorrectly.
> Mark them as offloaded only when HW offloading has been enabled.
> This should happen only for ADIN2111 when both ports are bridged
> by the software.
>
> Fixes: bc93e19d088b ("net: ethernet: adi: Add ADIN1110 support")
> Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
>
> [...]
Here is the summary with links:
- [net] net: ethernet: adi: adin1110: Fix multicast offloading
https://git.kernel.org/netdev/net/c/8a4f6d023221
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-24 5:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-20 9:08 [net] net: ethernet: adi: adin1110: Fix multicast offloading Alexandru Tachici
2023-01-24 1:45 ` Andrew Lunn
2023-01-24 5:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).