From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
andrew.gospodarek@broadcom.com, davem@davemloft.net,
edumazet@google.com, jgg@ziepe.ca, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, michael.chan@broadcom.com,
netdev@vger.kernel.org, pabeni@redhat.com,
selvin.xavier@broadcom.com
Subject: Re: [PATCH net-next v8 1/8] bnxt_en: Add auxiliary driver support
Date: Tue, 24 Jan 2023 08:49:19 +0200 [thread overview]
Message-ID: <Y89/b4kdiXlFzkOl@unreal> (raw)
In-Reply-To: <20230123223305.30c586ee@kernel.org>
On Mon, Jan 23, 2023 at 10:33:05PM -0800, Jakub Kicinski wrote:
> On Thu, 19 Jan 2023 22:05:28 -0800 Ajit Khaparde wrote:
> > @@ -13212,6 +13214,7 @@ static void bnxt_remove_one(struct pci_dev *pdev)
> > kfree(bp->rss_indir_tbl);
> > bp->rss_indir_tbl = NULL;
> > bnxt_free_port_stats(bp);
> > + bnxt_aux_priv_free(bp);
> > free_netdev(dev);
>
> You're still freeing the memory in which struct device sits regardless
> of its reference count.
BTW, Ajit does the same wrong kfree in bnxt_rdma_aux_device_add() too.
+ ret = auxiliary_device_add(aux_dev);
+ if (ret)
+ goto aux_dev_uninit;
+
...
+aux_dev_uninit:
+ auxiliary_device_uninit(aux_dev);
+free_edev:
+ kfree(edev); <----- wrong
+ bp->edev = NULL;
Thanks
next prev parent reply other threads:[~2023-01-24 6:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 6:05 [PATCH net-next v8 0/8] Add Auxiliary driver support Ajit Khaparde
2023-01-20 6:05 ` [PATCH net-next v8 1/8] bnxt_en: Add auxiliary " Ajit Khaparde
2023-01-24 6:33 ` Jakub Kicinski
2023-01-24 6:42 ` Greg Kroah-Hartman
2023-01-24 7:07 ` Ajit Khaparde
2023-01-24 7:38 ` Greg Kroah-Hartman
2023-01-24 6:49 ` Leon Romanovsky [this message]
2023-01-24 7:08 ` Ajit Khaparde
2023-01-20 6:05 ` [PATCH net-next v8 2/8] RDMA/bnxt_re: Use auxiliary driver interface Ajit Khaparde
2023-01-20 6:05 ` [PATCH net-next v8 3/8] bnxt_en: Remove usage of ulp_id Ajit Khaparde
2023-01-20 6:05 ` [PATCH net-next v8 4/8] bnxt_en: Use direct API instead of indirection Ajit Khaparde
2023-01-20 6:05 ` [PATCH net-next v8 5/8] bnxt_en: Use auxiliary bus calls over proprietary calls Ajit Khaparde
2023-01-20 6:05 ` [PATCH net-next v8 6/8] bnxt_en: Remove struct bnxt access from RoCE driver Ajit Khaparde
2023-01-20 6:05 ` [PATCH net-next v8 7/8] RDMA/bnxt_re: Remove the sriov config callback Ajit Khaparde
2023-01-20 6:05 ` [PATCH net-next v8 8/8] bnxt_en: Remove runtime interrupt vector allocation Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y89/b4kdiXlFzkOl@unreal \
--to=leon@kernel.org \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=selvin.xavier@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).