From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA130C54EBD for ; Fri, 13 Jan 2023 08:01:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240926AbjAMIBB (ORCPT ); Fri, 13 Jan 2023 03:01:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240425AbjAMH74 (ORCPT ); Fri, 13 Jan 2023 02:59:56 -0500 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 322B66B5D1 for ; Thu, 12 Jan 2023 23:59:53 -0800 (PST) Received: by mail-ed1-x533.google.com with SMTP id c17so30071232edj.13 for ; Thu, 12 Jan 2023 23:59:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wnHbH8z/0UrE79uXH0uK/safm3GXRV2WsqxSNHfUHA4=; b=rxQ12wFZZic/MFea44lF/Hxy4P9PqtVLt/sd0DBj1WEJ1ycC/bwQncVuuv7XOf2aHd kBKvBOtwPhmnfPVAZeB7sf5OR0eeMMfHaUka7mYMIFCuu+tv86U2QrqAmGHb+NIyYGYv 5dmvCApyCHhsKrYyWEAHwXIFOdVSsS7EKaFF4qFH9eRjENMiBkfDOxyBb+m+TlF76cPg 3R0uJGYkGC6cYG+mVNJVVXkws0yHmkJhLt8U65Zg5YHfW27RQ0g2FaZo4gmsu5qq29a6 1s33RTc0zMsftLiUumpauZtBo+u1rTDkp9HpMzVlZp+5GxS0aLl/hbuD6d/BEqlFJ5+f p7NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wnHbH8z/0UrE79uXH0uK/safm3GXRV2WsqxSNHfUHA4=; b=ZtfW9I5UOhCBSWtmNXBIpxkjbAKdo/iOH12YyVnTi6bDkM+HkFcSP1v5zK9tmSeU6V +AxY1IXY1+8es5tGAX+YBvhMRqMy2Gk/tgL81DgHHy3zi60Mz7pgjBuaIyrLybwRpI/V dQLvxqh4HhKY5fZqX9wFtyAzm6TWnib4pioK26XL4Q480ZrS/Irx7eC4loeEBqphWC/0 NFfCK5lM8Nma0a1uccAfSCfVwR16/ln9tN6kmMggvVSVRgGiztORnvqZlTSSTPfd0S9Z Whj+TAV1pxR2v2W3W2mgmyOn8lwodmnMQ2O4P5MeHMKsec8ec6CPEpC2mxW02vZpRBWr Mb/g== X-Gm-Message-State: AFqh2kqnnfYkkYE7ZZG13ybM/fqpm4Ymo88RRR8nIRbRpzHF5CPdhAeV rvw/YrTYSWM/QE1zxD7rI+9c4Q== X-Google-Smtp-Source: AMrXdXvtEvPEYWoZ0f7Fe2+oPQjlgmtPeXy4VZF3RjDLZ+zvzlJFCsGVs6p6MFOHfPEvL9oqgVQOdA== X-Received: by 2002:a05:6402:548b:b0:49c:869e:6134 with SMTP id fg11-20020a056402548b00b0049c869e6134mr706953edb.8.1673596792363; Thu, 12 Jan 2023 23:59:52 -0800 (PST) Received: from localhost ([217.111.27.204]) by smtp.gmail.com with ESMTPSA id u9-20020a056402110900b00499d0d78540sm3381660edv.39.2023.01.12.23.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Jan 2023 23:59:51 -0800 (PST) Date: Fri, 13 Jan 2023 08:59:50 +0100 From: Jiri Pirko To: Dan Carpenter Cc: Ido Schimmel , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] devlink: remove some unnecessary code Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fri, Jan 13, 2023 at 08:35:43AM CET, error27@gmail.com wrote: >This code checks if (attrs[DEVLINK_ATTR_TRAP_POLICER_ID]) twice. Once >at the start of the function and then a couple lines later. Delete the >second check since that one must be true. > >Because the second condition is always true, it means the: > > policer_item = group_item->policer_item; > >assignment is immediately over-written. Delete that as well. > >Signed-off-by: Dan Carpenter Reviewed-by: Jiri Pirko