From: Maxim Mikityanskiy <maxtram95@gmail.com>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, sgoutham@marvell.com, lcherian@marvell.com,
gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [net-next PATCH 4/5] octeontx2-pf: Add devlink support to configure TL1 RR_PRIO
Date: Fri, 13 Jan 2023 14:19:05 +0200 [thread overview]
Message-ID: <Y8FMOa8ORJ8gGMLX@mail.gmail.com> (raw)
In-Reply-To: <20230112173120.23312-5-hkelam@marvell.com>
On Thu, Jan 12, 2023 at 11:01:19PM +0530, Hariprasad Kelam wrote:
> All VFs and PF netdev shares same TL1 schedular, each interface
> PF or VF will have different TL2 schedulars having same parent
> TL1. The TL1 RR_PRIO value is static and PF/VFs use the same value
> to configure its TL2 node priority in case of DWRR children.
>
> This patch adds support to configure TL1 RR_PRIO value using devlink.
> The TL1 RR_PRIO can be configured for each PF. The VFs are not allowed
> to configure TL1 RR_PRIO value. The VFs can get the RR_PRIO value from
> the mailbox NIX_TXSCH_ALLOC response parameter aggr_lvl_rr_prio.
>
> Example command to configure TL1 RR_PRIO to 6 for PF 0002:04:00.0:
> $ devlink -p dev param set pci/0002:04:00.0 name tl1_rr_prio value 6 \
> cmode runtime
Could you please elaborate how these priorities of Transmit Levels are
related to HTB priorities? I don't seem to understand why something has
to be configured with devlink in addition to HTB.
Also, what do MDQ and SMQ abbreviations mean?
(Ccing Jiri for devlink stuff.)
>
> Limitations:
> 1. The RR_PRIO can only be configured before VFs are enabled
>
> Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
> Signed-off-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
> ---
next prev parent reply other threads:[~2023-01-13 12:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-12 17:31 [net-next PATCH 0/5] octeontx2-pf: HTB offload support Hariprasad Kelam
2023-01-12 17:31 ` [net-next PATCH 1/5] sch_htb: Allow HTB priority parameter in offload mode Hariprasad Kelam
2023-01-13 12:19 ` Maxim Mikityanskiy
2023-01-13 21:06 ` Rahul Rameshbabu
2023-01-14 1:50 ` Maxim Mikityanskiy
2023-01-14 2:18 ` Rahul Rameshbabu
2023-01-16 11:27 ` Maxim Mikityanskiy
2023-01-16 5:18 ` Hariprasad Kelam
2023-01-18 4:31 ` Rahul Rameshbabu
2023-01-12 17:31 ` [net-next PATCH 2/5] octeontx2-pf: qos send queues management Hariprasad Kelam
2023-01-12 17:31 ` [net-next PATCH 3/5] octeontx2-pf: Refactor schedular queue alloc/free calls Hariprasad Kelam
2023-01-12 17:31 ` [net-next PATCH 4/5] octeontx2-pf: Add devlink support to configure TL1 RR_PRIO Hariprasad Kelam
2023-01-13 12:19 ` Maxim Mikityanskiy [this message]
2023-01-12 17:31 ` [net-next PATCH 5/5] octeontx2-pf: Add support for HTB offload Hariprasad Kelam
2023-01-13 12:18 ` Maxim Mikityanskiy
2023-01-13 5:07 ` [net-next PATCH 0/5] octeontx2-pf: HTB offload support Jakub Kicinski
2023-01-13 6:20 ` Rahul Rameshbabu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8FMOa8ORJ8gGMLX@mail.gmail.com \
--to=maxtram95@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).