From: Greg KH <gregkh@linuxfoundation.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com,
Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
netdev@vger.kernel.org, johan@kernel.org, jirislaby@kernel.org,
Alexander Lobakin <alexandr.lobakin@intel.com>,
Karol Kolacinski <karol.kolacinski@intel.com>,
Michal Michalik <michal.michalik@intel.com>,
Gurucharan G <gurucharanx.g@intel.com>
Subject: Re: [PATCH net-next 1/1] ice: use GNSS subsystem instead of TTY
Date: Sat, 14 Jan 2023 08:03:15 +0100 [thread overview]
Message-ID: <Y8JTsxcUsZHG2AHU@kroah.com> (raw)
In-Reply-To: <20230113214852.970949-1-anthony.l.nguyen@intel.com>
On Fri, Jan 13, 2023 at 01:48:52PM -0800, Tony Nguyen wrote:
> From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
>
> Previously support for GNSS was implemented as a TTY driver, it allowed
> to access GNSS receiver on /dev/ttyGNSS_<bus><func>.
>
> Use generic GNSS subsystem API instead of implementing own TTY driver.
> The receiver is accessible on /dev/gnss<id>. In case of multiple
> receivers in the OS, correct device can be found by enumerating either:
> - /sys/class/net/<eth port>/device/gnss/
> - /sys/class/gnss/gnss<id>/device/
You are saying what you are doing, but not anything about _why_ this
change is the correct one.
You are also breaking a user/kernel api here, how is existing users
going to handle the tty device node going away? What userspace tools
are going to break and how are you going to handle that?
While overall I like the idea here, you aren't really providing any
justification for it at all.
thanks,
greg k-h
next prev parent reply other threads:[~2023-01-14 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 21:48 [PATCH net-next 1/1] ice: use GNSS subsystem instead of TTY Tony Nguyen
2023-01-14 7:03 ` Greg KH [this message]
2023-01-16 17:03 ` Kubalewski, Arkadiusz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8JTsxcUsZHG2AHU@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alexandr.lobakin@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gurucharanx.g@intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=karol.kolacinski@intel.com \
--cc=kuba@kernel.org \
--cc=michal.michalik@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).