From: Simon Horman <simon.horman@corigine.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2 09/10] tc: use SPDX
Date: Sat, 14 Jan 2023 16:42:25 +0100 [thread overview]
Message-ID: <Y8LNYWVRFK/fvo+A@corigine.com> (raw)
In-Reply-To: <20230113093203.50235913@hermes.local>
On Fri, Jan 13, 2023 at 09:32:03AM -0800, Stephen Hemminger wrote:
> On Fri, 13 Jan 2023 11:34:59 +0100
> Simon Horman <simon.horman@corigine.com> wrote:
>
> > On Tue, Jan 10, 2023 at 07:17:11PM -0800, Stephen Hemminger wrote:
> > > Replace GPL boilerplate with SPDX.
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >
> > ...
> >
> > > #include <stdio.h>
> > > diff --git a/tc/q_atm.c b/tc/q_atm.c
> > > index 77b56825f777..07866ccf2fce 100644
> > > --- a/tc/q_atm.c
> > > +++ b/tc/q_atm.c
> > > @@ -3,7 +3,6 @@
> > > * q_atm.c ATM.
> > > *
> > > * Hacked 1998-2000 by Werner Almesberger, EPFL ICA
> > > - *
> > > */
> > >
> > > #include <stdio.h>
> >
> > Maybe add an SPDX header here?
> > I assume it is GPL-2.0-or-later.
> > Or is that pushing our luck?
> >
> > > #include <stdio.h>
> > > diff --git a/tc/q_dsmark.c b/tc/q_dsmark.c
> > > index d3e8292d777c..9adceba59c99 100644
> > > --- a/tc/q_dsmark.c
> > > +++ b/tc/q_dsmark.c
> > > @@ -3,7 +3,6 @@
> > > * q_dsmark.c Differentiated Services field marking.
> > > *
> > > * Hacked 1998,1999 by Werner Almesberger, EPFL ICA
> > > - *
> > > */
> > >
> > > #include <stdio.h>
> >
> > Ditto.
>
> Both q_dsmark.c and q_atm.c for 1st pass on using SPDX
> and both had no previous specific license text.
>
> At the time, my arbitrary decision was that if no other license
> was specified the original author expected that the code would
> be GPL2.0 only like the kernel.
Fair enough. In that light I agree with the approach you have taken.
next prev parent reply other threads:[~2023-01-14 15:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 3:17 [PATCH iproute2 00/10] SPDX cleanups Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 01/10] bridge: use SPDX Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 02/10] genl: " Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 03/10] lib: replace GPL boilerplate with SPDX Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 04/10] devlink: use SPDX Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 05/10] ip: " Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 06/10] testsuite: " Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 07/10] tipc: " Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 08/10] tc: replace GPL-BSD boilerplate in codel and fq Stephen Hemminger
2023-01-11 3:17 ` [PATCH iproute2 09/10] tc: use SPDX Stephen Hemminger
2023-01-13 10:34 ` Simon Horman
2023-01-13 17:32 ` Stephen Hemminger
2023-01-14 15:42 ` Simon Horman [this message]
2023-01-11 3:17 ` [PATCH iproute2 10/10] misc: " Stephen Hemminger
2023-01-13 10:36 ` [PATCH iproute2 00/10] SPDX cleanups Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8LNYWVRFK/fvo+A@corigine.com \
--to=simon.horman@corigine.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).