From: Cong Wang <xiyou.wangcong@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com,
Linux Kernel Functional Testing <lkft@linaro.org>,
jhs@mojatatu.com, jiri@resnulli.us, john.hurley@netronome.com
Subject: Re: [PATCH net] net: sched: gred: prevent races when adding offloads to stats
Date: Sat, 14 Jan 2023 18:20:29 -0800 [thread overview]
Message-ID: <Y8Ni7XYRj5/feifn@pop-os.localdomain> (raw)
In-Reply-To: <20230113044137.1383067-1-kuba@kernel.org>
On Thu, Jan 12, 2023 at 08:41:37PM -0800, Jakub Kicinski wrote:
> Naresh reports seeing a warning that gred is calling
> u64_stats_update_begin() with preemption enabled.
> Arnd points out it's coming from _bstats_update().
The stack trace looks confusing to me without further decoding.
Are you sure we use sch->qstats/bstats in __dev_queue_xmit() there
not any netdev stats? It may be a false positive one as they may end up
with the same lockdep class.
Thanks.
next prev parent reply other threads:[~2023-01-15 2:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 4:41 [PATCH net] net: sched: gred: prevent races when adding offloads to stats Jakub Kicinski
2023-01-15 2:20 ` Cong Wang [this message]
2023-01-17 9:00 ` Paolo Abeni
2023-01-17 19:10 ` Jakub Kicinski
2023-01-19 20:19 ` Cong Wang
2023-01-19 21:16 ` Jakub Kicinski
2023-01-19 20:17 ` Cong Wang
2023-01-19 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8Ni7XYRj5/feifn@pop-os.localdomain \
--to=xiyou.wangcong@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=john.hurley@netronome.com \
--cc=kuba@kernel.org \
--cc=lkft@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).