From: Andrew Lunn <andrew@lunn.ch>
To: Pierluigi Passaro <pierluigi.p@variscite.com>
Cc: wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com,
linux-imx@nxp.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, eran.m@variscite.com,
nate.d@variscite.com, francesco.f@variscite.com,
pierluigi.passaro@gmail.com
Subject: Re: [PATCH v2] net: fec: manage corner deferred probe condition
Date: Sun, 15 Jan 2023 22:56:33 +0100 [thread overview]
Message-ID: <Y8R2kQMwgdgE6Qlp@lunn.ch> (raw)
In-Reply-To: <20230115213804.26650-1-pierluigi.p@variscite.com>
On Sun, Jan 15, 2023 at 10:38:04PM +0100, Pierluigi Passaro wrote:
> For dual fec interfaces, external phys can only be configured by fec0.
> When the function of_mdiobus_register return -EPROBE_DEFER, the driver
> is lately called to manage fec1, which wrongly register its mii_bus as
> fec0_mii_bus.
> When fec0 retry the probe, the previous assignement prevent the MDIO bus
> registration.
> Use a static boolean to trace the orginal MDIO bus deferred probe and
> prevent further registrations until the fec0 registration completed
> succesfully.
The real problem here seems to be that fep->dev_id is not
deterministic. I think a better fix would be to make the mdio bus name
deterministic. Use pdev->id instead of fep->dev_id + 1. That is what
most mdiobus drivers use.
Andrew
next prev parent reply other threads:[~2023-01-15 21:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 21:38 [PATCH v2] net: fec: manage corner deferred probe condition Pierluigi Passaro
2023-01-15 21:56 ` Andrew Lunn [this message]
2023-01-15 22:23 ` Pierluigi Passaro
2023-01-16 0:01 ` Andrew Lunn
2023-01-16 8:51 ` Pierluigi Passaro
2023-01-16 15:32 ` Andrew Lunn
2023-01-16 20:23 ` Pierluigi Passaro
2023-01-17 5:54 ` Wei Fang
2023-01-17 14:17 ` Andrew Lunn
2023-01-16 7:35 ` Alexander Stein
2023-01-16 19:19 ` Pierluigi Passaro
2023-01-17 12:55 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8R2kQMwgdgE6Qlp@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eran.m@variscite.com \
--cc=francesco.f@variscite.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nate.d@variscite.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pierluigi.p@variscite.com \
--cc=pierluigi.passaro@gmail.com \
--cc=shenwei.wang@nxp.com \
--cc=wei.fang@nxp.com \
--cc=xiaoning.wang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).