From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC85C54EBE for ; Mon, 16 Jan 2023 07:30:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231794AbjAPHaN (ORCPT ); Mon, 16 Jan 2023 02:30:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231572AbjAPHaL (ORCPT ); Mon, 16 Jan 2023 02:30:11 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5ED2CC3E; Sun, 15 Jan 2023 23:30:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2C116B80D4F; Mon, 16 Jan 2023 07:30:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D346DC433EF; Mon, 16 Jan 2023 07:30:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673854207; bh=jXP2JXB7Ja6faI+t920dtDx9s48lo99uDFqGi3cMdhw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VK+QZeSWbPl0U8+isx6i4jz2rn9oy1VODqKr38KsZXjCMeAqSZA/A4eMJdnwspzkh 65MbSoS5WsO/JDgc3cpRkJGE+4/qn51o1kxPtCJ6gmMfzdURyKL9EmcIUy3ZsJrNEf Vjwhlm06y8oA9M18TLEUhavuVDzEaeixoK+azBQ6aix1HBLD0LcSMg1krWKyG7PJVw 3T5Li7ET4uf8lXNliDioT+CRNmm9doSo7ioiE1bqt/dfA+MvKLCmDwM7e5u/TxdscZ iQPnGp8x5cbi+8NEwGKKGfph3iz3KmDX4FtYQmfChLXMAHCRG7kRW08j4Hv88Q5DCp 1Tubn8uVHcDQA== Date: Mon, 16 Jan 2023 09:30:02 +0200 From: Leon Romanovsky To: Siddharth Vadapalli Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, linux@armlinux.org.uk, pabeni@redhat.com, rogerq@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, vigneshr@ti.com, srk@ti.com Subject: Re: [PATCH net-next v2] net: ethernet: ti: am65-cpsw/cpts: Fix CPTS release action Message-ID: References: <20230116044517.310461-1-s-vadapalli@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230116044517.310461-1-s-vadapalli@ti.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 16, 2023 at 10:15:17AM +0530, Siddharth Vadapalli wrote: > The am65_cpts_release() function is registered as a devm_action in the > am65_cpts_create() function in am65-cpts driver. When the am65-cpsw driver > invokes am65_cpts_create(), am65_cpts_release() is added in the set of devm > actions associated with the am65-cpsw driver's device. > > In the event of probe failure or probe deferral, the platform_drv_probe() > function invokes dev_pm_domain_detach() which powers off the CPSW and the > CPSW's CPTS hardware, both of which share the same power domain. Since the > am65_cpts_disable() function invoked by the am65_cpts_release() function > attempts to reset the CPTS hardware by writing to its registers, the CPTS > hardware is assumed to be powered on at this point. However, the hardware > is powered off before the devm actions are executed. > > Fix this by getting rid of the devm action for am65_cpts_release() and > invoking it directly on the cleanup and exit paths. > > Fixes: f6bd59526ca5 ("net: ethernet: ti: introduce am654 common platform time sync driver") > Signed-off-by: Siddharth Vadapalli > Reviewed-by: Roger Quadros > --- > Changes from v1: > 1. Fix the build issue when "CONFIG_TI_K3_AM65_CPTS" is not set. This > error was reported by kernel test robot at: > https://lore.kernel.org/r/202301142105.lt733Lt3-lkp@intel.com/ > 2. Collect Reviewed-by tag from Roger Quadros. > > v1: > https://lore.kernel.org/r/20230113104816.132815-1-s-vadapalli@ti.com/ > > drivers/net/ethernet/ti/am65-cpsw-nuss.c | 8 ++++++++ > drivers/net/ethernet/ti/am65-cpts.c | 15 +++++---------- > drivers/net/ethernet/ti/am65-cpts.h | 5 +++++ > 3 files changed, 18 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > index 5cac98284184..00f25d8a026b 100644 > --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c > +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c > @@ -1913,6 +1913,12 @@ static int am65_cpsw_am654_get_efuse_macid(struct device_node *of_node, > return 0; > } > > +static void am65_cpsw_cpts_cleanup(struct am65_cpsw_common *common) > +{ > + if (IS_ENABLED(CONFIG_TI_K3_AM65_CPTS) && common->cpts) Why do you have IS_ENABLED(CONFIG_TI_K3_AM65_CPTS), if am65_cpts_release() defined as empty when CONFIG_TI_K3_AM65_CPTS not set? How is it possible to have common->cpts == NULL? And why do you need special am65_cpsw_cpts_cleanup() which does nothing except call to am65_cpts_release()? It will be more intuitive change the latter to be exported function. Thanks