From: Leon Romanovsky <leon@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: yang.yang29@zte.com.cn, aspriel@gmail.com,
franky.lin@broadcom.com, hante.meuleman@broadcom.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
sha-cyfmac-dev-list@infineon.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xu.panda@zte.com.cn
Subject: Re: [PATCH net-next] brcm80211: use strscpy() to instead of strncpy()
Date: Mon, 16 Jan 2023 15:31:19 +0200 [thread overview]
Message-ID: <Y8VRpzodki/YAcvC@unreal> (raw)
In-Reply-To: <167387451256.32134.6493247488948126794.kvalo@kernel.org>
On Mon, Jan 16, 2023 at 01:08:36PM +0000, Kalle Valo wrote:
> <yang.yang29@zte.com.cn> wrote:
>
> > From: Xu Panda <xu.panda@zte.com.cn>
> >
> > The implementation of strscpy() is more robust and safer.
> > That's now the recommended way to copy NUL-terminated strings.
> >
> > Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
> > Signed-off-by: Yang Yang <yang.yang29@zte.com>
>
> Mismatch email in From and Signed-off-by lines:
>
> From: <yang.yang29@zte.com.cn>
> Signed-off-by: Yang Yang <yang.yang29@zte.com>
>
> Patch set to Changes Requested.
Kalle, please be aware of this response
https://lore.kernel.org/netdev/20230113112817.623f58fa@kernel.org/
"I don't trust that you know what you're doing. So please don't send
any more strncpy() -> strscpy() conversions for networking."
Thanks
>
> --
> https://patchwork.kernel.org/project/linux-wireless/patch/202212231037210142246@zte.com.cn/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
>
next prev parent reply other threads:[~2023-01-16 13:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-23 2:37 [PATCH net-next] brcm80211: use strscpy() to instead of strncpy() yang.yang29
2023-01-16 13:08 ` Kalle Valo
2023-01-16 13:31 ` Leon Romanovsky [this message]
2023-01-16 15:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8VRpzodki/YAcvC@unreal \
--to=leon@kernel.org \
--cc=aspriel@gmail.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sha-cyfmac-dev-list@infineon.com \
--cc=xu.panda@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).