From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E55FC63797 for ; Tue, 17 Jan 2023 14:13:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231661AbjAQON5 (ORCPT ); Tue, 17 Jan 2023 09:13:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232250AbjAQONm (ORCPT ); Tue, 17 Jan 2023 09:13:42 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDF153BD86; Tue, 17 Jan 2023 06:13:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=kkWpEbdhvO9/WJMoBB3MOxQsl6iaZufmOeTDARQQiuM=; b=RusiT9QT2rv87W+fSdOaBIPtk2 dfGWgfX+1Hj73f0cxDv+9PxhuIwIVLCHIHmW0+ONwGfQztRC3+9fmE4hElqwowvjFw9gGmgNKYNMc z08s0j/mqLljUnuNUG+YnPaNb1V0FWPMWNdueaxC79cKZVFLLU4rGNw1pgS4kmPp/XXA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pHmiQ-002KUd-8i; Tue, 17 Jan 2023 15:13:30 +0100 Date: Tue, 17 Jan 2023 15:13:30 +0100 From: Andrew Lunn To: Lars-Peter Clausen Cc: Pierluigi Passaro , hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, eran.m@variscite.com, nate.d@variscite.com, francesco.f@variscite.com, pierluigi.p@variscite.com Subject: Re: [PATCH] net: mdio: force deassert MDIO reset signal Message-ID: References: <20230115161006.16431-1-pierluigi.p@variscite.com> <54eb0ee4-7d9e-7025-f984-b1e026c18c3d@metafoo.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54eb0ee4-7d9e-7025-f984-b1e026c18c3d@metafoo.de> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > > I think part of the problem is that for C45 there are a few other fields > > > that get populated by the ID detection, such as devices_in_package and > > > mmds_present. Is this something we can do after running the PHY drivers > > > probe function? Or is it too late at that point? > > As i hinted, it needs somebody to actually debug this and figure out > > why it does not work. > > > > I think what i did above is part of the solution. You need to actually > > read the ID from the DT, which if you never call fwnode_get_phy_id() > > you never do. > > > > You then need to look at phy_bus_match() and probably remove the > > > > return 0; > > } else { > > > > so that C22 style ID matching is performed if matching via > > c45_ids.device_ids fails. > > Sorry, I've should have been more clear. I did try your proposed change a > while ago. The problem why it does not work is that there are other fields > in the phy data structure that get initialized when reading the IDs for C45. > Such as which MMD addresses are valid. So lets take this one step at a time. Does this change at least get the driver loaded? There is some code in phy-c45.c which needs phydev->c45_ids.mmds_present. So maybe after the driver has probed, and the device should be accessible, we need to call get_phy_c45_ids() to fill in the missing IDs? Andrew