From: Maxim Mikityanskiy <maxtram95@gmail.com>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com,
edumazet@google.com, sgoutham@marvell.com, lcherian@marvell.com,
gakula@marvell.com, jerinj@marvell.com, sbhatta@marvell.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
saeedm@nvidia.com, richardcochran@gmail.com, tariqt@nvidia.com,
linux-rdma@vger.kernel.org
Subject: Re: [net-next Patch v2 4/5] octeontx2-pf: Add devlink support to configure TL1 RR_PRIO
Date: Wed, 18 Jan 2023 22:37:41 +0200 [thread overview]
Message-ID: <Y8hYlYk/7FfGdfy8@mail.gmail.com> (raw)
In-Reply-To: <20230118105107.9516-5-hkelam@marvell.com>
On Wed, Jan 18, 2023 at 04:21:06PM +0530, Hariprasad Kelam wrote:
> All VFs and PF netdev shares same TL1 schedular, each interface
> PF or VF will have different TL2 schedulars having same parent
> TL1. The TL1 RR_PRIO value is static and PF/VFs use the same value
> to configure its TL2 node priority in case of DWRR children.
>
> This patch adds support to configure TL1 RR_PRIO value using devlink.
> The TL1 RR_PRIO can be configured for each PF. The VFs are not allowed
> to configure TL1 RR_PRIO value. The VFs can get the RR_PRIO value from
> the mailbox NIX_TXSCH_ALLOC response parameter aggr_lvl_rr_prio.
I asked this question under v1, but didn't get an answer, could you shed
some light?
"Could you please elaborate how these priorities of Transmit Levels are
related to HTB priorities? I don't seem to understand why something has
to be configured with devlink in addition to HTB.
Also, what do MDQ and SMQ abbreviations mean?"
BTW, why did you remove the paragraphs with an example and a limitation?
I think they are pretty useful.
Another question unanswered under v1 was:
"Is there any technical difficulty or hardware limitation preventing from
implementing modifications?" (TC_HTB_NODE_MODIFY)
next prev parent reply other threads:[~2023-01-18 20:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-18 10:51 [net-next Patch v2 0/5] octeontx2-pf: HTB offload support Hariprasad Kelam
2023-01-18 10:51 ` [net-next Patch v2 1/5] sch_htb: Allow HTB priority parameter in offload mode Hariprasad Kelam
2023-01-18 10:51 ` [net-next Patch v2 2/5] octeontx2-pf: qos send queues management Hariprasad Kelam
2023-01-22 16:46 ` Simon Horman
2023-01-23 17:26 ` Hariprasad Kelam
2023-01-18 10:51 ` [net-next Patch v2 3/5] octeontx2-pf: Refactor schedular queue alloc/free calls Hariprasad Kelam
2023-01-18 10:51 ` [net-next Patch v2 4/5] octeontx2-pf: Add devlink support to configure TL1 RR_PRIO Hariprasad Kelam
2023-01-18 20:37 ` Maxim Mikityanskiy [this message]
2023-01-20 8:50 ` Hariprasad Kelam
2023-01-20 13:37 ` Maxim Mikityanskiy
2023-01-20 17:03 ` Hariprasad Kelam
2023-01-22 13:18 ` Maxim Mikityanskiy
2023-01-23 17:03 ` Hariprasad Kelam
2023-01-23 20:05 ` Maxim Mikityanskiy
2023-01-23 22:45 ` Jakub Kicinski
2023-01-23 23:01 ` Maxim Mikityanskiy
2023-01-24 11:49 ` Hariprasad Kelam
2023-01-24 13:02 ` Maxim Mikityanskiy
2023-01-25 1:26 ` Jakub Kicinski
2023-01-26 17:16 ` Hariprasad Kelam
2023-01-23 22:44 ` Jakub Kicinski
2023-01-18 10:51 ` [net-next Patch v2 5/5] octeontx2-pf: Add support for HTB offload Hariprasad Kelam
-- strict thread matches above, loose matches on Subject: below --
2023-01-18 10:04 [net-next Patch v2 0/5] octeontx2-pf: HTB offload support Hariprasad Kelam
2023-01-18 10:04 ` [net-next Patch v2 4/5] octeontx2-pf: Add devlink support to configure TL1 RR_PRIO Hariprasad Kelam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8hYlYk/7FfGdfy8@mail.gmail.com \
--to=maxtram95@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=tariqt@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).