From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: netdev@vger.kernel.org, Felix Fietkau <nbd@nbd.name>,
John Crispin <john@phrozen.org>,
Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Daniel Golle <daniel@makrotopia.org>,
Alexander Couzens <lynxis@fe80.eu>
Subject: Re: [PATCH v2 net 1/3] net: mediatek: sgmii: ensure the SGMII PHY is powered down on configuration
Date: Fri, 20 Jan 2023 12:27:15 +0000 [thread overview]
Message-ID: <Y8qIoxpLj2uiRM1Q@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230120104947.4048820-2-bjorn@mork.no>
On Fri, Jan 20, 2023 at 11:49:45AM +0100, Bjørn Mork wrote:
> From: Alexander Couzens <lynxis@fe80.eu>
>
> The code expect the PHY to be in power down which is only true after reset.
> Allow changes of the SGMII parameters more than once.
>
> Only power down when reconfiguring to avoid bouncing the link when there's
> no reason to - based on code from Russell King.
>
> There are cases when the SGMII_PHYA_PWD register contains 0x9 which
> prevents SGMII from working. The SGMII still shows link but no traffic
> can flow. Writing 0x0 to the PHYA_PWD register fix the issue. 0x0 was
> taken from a good working state of the SGMII interface.
>
> Suggested-by: Russell King (Oracle) <linux@armlinux.org.uk>
> Signed-off-by: Alexander Couzens <lynxis@fe80.eu>
> [ bmork: rebased and squashed into one patch ]
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Thanks!
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-01-20 12:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 10:49 [PATCH v2 net 0/3] fixes for mtk_eth_soc Bjørn Mork
2023-01-20 10:49 ` [PATCH v2 net 1/3] net: mediatek: sgmii: ensure the SGMII PHY is powered down on configuration Bjørn Mork
2023-01-20 12:27 ` Russell King (Oracle) [this message]
2023-01-20 10:49 ` [PATCH v2 net 2/3] net: mediatek: sgmii: fix duplex configuration Bjørn Mork
2023-01-20 10:49 ` [PATCH v2 net 3/3] mtk_sgmii: enable PCS polling to allow SFP work Bjørn Mork
2023-01-20 12:29 ` Russell King (Oracle)
2023-01-20 12:48 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8qIoxpLj2uiRM1Q@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=Mark-MC.Lee@mediatek.com \
--cc=bjorn@mork.no \
--cc=daniel@makrotopia.org \
--cc=john@phrozen.org \
--cc=lorenzo@kernel.org \
--cc=lynxis@fe80.eu \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).