From: Dan Carpenter <error27@gmail.com>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: Daniel Machon <daniel.machon@microchip.com>,
UNGLinuxDriver@microchip.com,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Horatiu Vultur <horatiu.vultur@microchip.com>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
Lars Povlsen <lars.povlsen@microchip.com>
Subject: Re: [PATCH net-next] net: microchip: sparx5: Fix uninitialized variable in vcap_path_exist()
Date: Fri, 20 Jan 2023 18:10:34 +0300 [thread overview]
Message-ID: <Y8qu6s4nmOQB8ZEq@kadam> (raw)
In-Reply-To: <ebcb9a2321ea39ac5164e5df635c2eb02835f41c.camel@microchip.com>
On Fri, Jan 20, 2023 at 03:25:36PM +0100, Steen Hegelund wrote:
> Hi Dan,
>
> Thanks for the fix.
>
> I have not seen any CONFIG_INIT_STACK_ALL=y in any of my .configs, though, so I
> will be updating my test suite to catch this.
No, what I'm saying is that for a lot of people all stack variables are
initialized to zero by default so sometimes people are like, "I've
tested this a thousand times. How has it even been working?"
In your case I guess it was working because the eport was never not
found.
regards,
dan carpenter
next prev parent reply other threads:[~2023-01-20 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 13:47 [PATCH net-next] net: microchip: sparx5: Fix uninitialized variable in vcap_path_exist() Dan Carpenter
2023-01-20 14:25 ` Steen Hegelund
2023-01-20 15:10 ` Dan Carpenter [this message]
2023-01-24 5:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8qu6s4nmOQB8ZEq@kadam \
--to=error27@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox