From: Andrew Lunn <andrew@lunn.ch>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
michael@walle.cc
Subject: Re: [PATCH net-next v2] net: micrel: Add support for lan8841 PHY
Date: Fri, 3 Feb 2023 15:22:37 +0100 [thread overview]
Message-ID: <Y90YrXHeyR6f26Px@lunn.ch> (raw)
In-Reply-To: <20230203122542.436305-1-horatiu.vultur@microchip.com>
> +{
> + char *rx_data_skews[4] = {"rxd0-skew-psec", "rxd1-skew-psec",
> + "rxd2-skew-psec", "rxd3-skew-psec"};
> + char *tx_data_skews[4] = {"txd0-skew-psec", "txd1-skew-psec",
> + "txd2-skew-psec", "txd3-skew-psec"};
Please take a read of
Documentation/devicetree/bindings/net/micrel-ksz90x1.txt and then add
a section which describes what these properties mean for this PHY,
since nearly every microchip PHY has a different meaning :-(
Andrew
next prev parent reply other threads:[~2023-02-03 14:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 12:25 [PATCH net-next v2] net: micrel: Add support for lan8841 PHY Horatiu Vultur
2023-02-03 13:55 ` Heiner Kallweit
2023-02-03 15:10 ` Horatiu Vultur
2023-02-03 21:57 ` Heiner Kallweit
2023-02-04 10:12 ` Horatiu Vultur
2023-02-04 11:24 ` Heiner Kallweit
2023-02-03 14:22 ` Andrew Lunn [this message]
2023-02-03 15:25 ` Horatiu Vultur
2023-02-03 17:48 ` Andrew Lunn
2023-02-09 16:37 ` Russell King (Oracle)
2023-02-10 8:12 ` Horatiu Vultur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y90YrXHeyR6f26Px@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horatiu.vultur@microchip.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).