From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Shannon Nelson <shannon.nelson@amd.com>, <netdev@vger.kernel.org>,
<davem@davemloft.net>, <drivers@pensando.io>,
Neel Patel <neel.patel@amd.com>
Subject: Re: [PATCH net-next 4/4] ionic: page cache for rx buffers
Date: Sat, 4 Feb 2023 12:09:23 +0100 [thread overview]
Message-ID: <Y9484wAMzK+byKeq@boxer> (raw)
In-Reply-To: <20230203202853.78fe8335@kernel.org>
On Fri, Feb 03, 2023 at 08:28:53PM -0800, Jakub Kicinski wrote:
> On Fri, 3 Feb 2023 13:00:16 -0800 Shannon Nelson wrote:
> > From: Neel Patel <neel.patel@amd.com>
> >
> > Use a local page cache to optimize page allocation & dma mapping.
>
> Please use the page_pool API rather than creating your own caches.
+1, please also add perf numbers on next revision
next prev parent reply other threads:[~2023-02-04 11:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 21:00 [PATCH net-next 0/4] ionic: rx buffers and on-chip descriptors Shannon Nelson
2023-02-03 21:00 ` [PATCH net-next 1/4] ionic: remove unnecessary indirection Shannon Nelson
2023-02-03 21:00 ` [PATCH net-next 2/4] ionic: remove unnecessary void casts Shannon Nelson
2023-02-03 21:00 ` [PATCH net-next 3/4] ionic: add support for device Component Memory Buffers Shannon Nelson
2023-02-03 21:00 ` [PATCH net-next 4/4] ionic: page cache for rx buffers Shannon Nelson
2023-02-04 4:28 ` Jakub Kicinski
2023-02-04 11:09 ` Maciej Fijalkowski [this message]
2023-02-06 17:25 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9484wAMzK+byKeq@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=kuba@kernel.org \
--cc=neel.patel@amd.com \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox