From: Jiri Pirko <jiri@resnulli.us>
To: Niklas Cassel <Niklas.Cassel@wdc.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jiri Pirko <jiri@nvidia.com>, Leon Romanovsky <leon@kernel.org>,
Michael Chan <michael.chan@broadcom.com>
Subject: Re: bnxt devl_assert_locked warning
Date: Wed, 25 Jan 2023 16:01:50 +0100 [thread overview]
Message-ID: <Y9FEXu1iyc4M8ODB@nanopsycho> (raw)
In-Reply-To: <Y9E/phvj/nZoqmR1@x1-carbon>
Wed, Jan 25, 2023 at 03:41:43PM CET, Niklas.Cassel@wdc.com wrote:
>On Wed, Jan 25, 2023 at 03:17:05PM +0100, Jiri Pirko wrote:
>> Wed, Jan 25, 2023 at 02:36:27PM CET, Niklas.Cassel@wdc.com wrote:
>> >Hello there,
>> >
>> >When testing next-20230124 and next-20230125 I get a warning about devlink
>> >lock not being held in the bnxt driver, at boot or when modprobing the driver.
>> >See trace below.
>> >
>> >I haven't seen this when testing just 1-2 weeks ago, so I assume that something
>> >that went in recently caused this.
>> >
>> >Searching lore.kernel.org/netdev shows that Jiri has done a lot of refactoring
>> >with regards to devlink locking recently, could that be related?
>>
>> Oh yeah, this is due to:
>> 63ba54a52c417a0c632a5f85a2b912b8a2320358
>>
>> I just set a patches that is fixing this taking devlink instance lock
>> for params operations:
>> https://lore.kernel.org/netdev/20230125141412.1592256-1-jiri@resnulli.us/
>
>Thank you Jiri!
>
>I applied the series, and I can no longer see the warning during boot.
Great. Thanks for testing!
>
>Kind regards,
>Niklas
prev parent reply other threads:[~2023-01-25 15:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 13:36 bnxt devl_assert_locked warning Niklas Cassel
2023-01-25 14:17 ` Jiri Pirko
2023-01-25 14:41 ` Niklas Cassel
2023-01-25 15:01 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9FEXu1iyc4M8ODB@nanopsycho \
--to=jiri@resnulli.us \
--cc=Niklas.Cassel@wdc.com \
--cc=jiri@nvidia.com \
--cc=leon@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).