From: Leon Romanovsky <leon@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Michal Kubecek <mkubecek@suse.cz>, Andrew Lunn <andrew@lunn.ch>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH net-next] net: ethtool: provide shims for stats aggregation helpers when CONFIG_ETHTOOL_NETLINK=n
Date: Thu, 26 Jan 2023 12:37:13 +0200 [thread overview]
Message-ID: <Y9JX2RU01Fgi+5GV@unreal> (raw)
In-Reply-To: <20230125110214.4127759-1-vladimir.oltean@nxp.com>
On Wed, Jan 25, 2023 at 01:02:14PM +0200, Vladimir Oltean wrote:
> ethtool_aggregate_*_stats() are implemented in net/ethtool/stats.c, a
> file which is compiled out when CONFIG_ETHTOOL_NETLINK=n. In order to
> avoid adding Kbuild dependencies from drivers (which call these helpers)
> on CONFIG_ETHTOOL_NETLINK, let's add some shim definitions which simply
> make the helpers dead code.
>
> This means the function prototypes should have been located in
> include/linux/ethtool_netlink.h rather than include/linux/ethtool.h.
>
> Fixes: 449c5459641a ("net: ethtool: add helpers for aggregate statistics")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> drivers/net/ethernet/mscc/ocelot_stats.c | 1 +
> include/linux/ethtool.h | 11 -------
> include/linux/ethtool_netlink.h | 42 ++++++++++++++++++++++++
> 3 files changed, 43 insertions(+), 11 deletions(-)
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-01-26 10:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 11:02 [PATCH net-next] net: ethtool: provide shims for stats aggregation helpers when CONFIG_ETHTOOL_NETLINK=n Vladimir Oltean
2023-01-26 10:37 ` Leon Romanovsky [this message]
2023-01-26 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9JX2RU01Fgi+5GV@unreal \
--to=leon@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lkp@intel.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).