From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13F55C05027 for ; Thu, 26 Jan 2023 19:17:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229962AbjAZTRM (ORCPT ); Thu, 26 Jan 2023 14:17:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229514AbjAZTRL (ORCPT ); Thu, 26 Jan 2023 14:17:11 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 394236185; Thu, 26 Jan 2023 11:17:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8ED7E60B55; Thu, 26 Jan 2023 19:17:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 34C50C433EF; Thu, 26 Jan 2023 19:17:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674760629; bh=qZW5kvveXCZHcR/ZqTwrsTUv+BB2nwUSCg4zBsaJH9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tAGSAWglttIMy99bfGZPzoDW6BfVFKVp/OJ9p9TL6bhcyHUAIWnaDEY1ck7ENRKBK Bv/w78fimWKWPySQLNdB9hcVRlNaXgjBmIyYLPNgoxd6yXMqSXsNH1yqsrQoG3wd+o MByT21tYwiwZLGCte0wRAtKRx+INlOTm9OjK0twjvj7KbXISBb2g+2z4MNqBD3ufnw GhYvvNYc1yd2yP0ndzzR5MCWbeT5Kp8zM9mIkOkvPfwVIFxLcIHQ8y4W0sZYId9gYC HK0PSHekWJqMor8pOGBMYH0o+l4xP3VMbSSDCMTZQJC3HXqggvS/kMtfyjEZ90NMK3 nF9VXFNdu0RPg== Date: Thu, 26 Jan 2023 21:17:04 +0200 From: Leon Romanovsky To: Paolo Abeni , Jakub Kicinski Cc: "David S . Miller" , Steffen Klassert , Andy Gospodarek , Ayush Sawal , Eric Dumazet , Herbert Xu , intel-wired-lan@lists.osuosl.org, Jay Vosburgh , Jesse Brandeburg , Jonathan Corbet , linux-doc@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@corigine.com, Raju Rangoju , Saeed Mahameed , Simon Horman , Tony Nguyen , Veaceslav Falico Subject: Re: [PATCH net-next v1 01/10] xfrm: extend add policy callback to set failure reason Message-ID: References: <20230125110226.66dc7eeb@kernel.org> <75f6e5d0e42a8b9895c1b2330c373da9ed7f41db.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 26, 2023 at 12:42:08PM +0200, Leon Romanovsky wrote: > On Thu, Jan 26, 2023 at 10:45:50AM +0100, Paolo Abeni wrote: > > On Thu, 2023-01-26 at 09:28 +0200, Leon Romanovsky wrote: > > > On Wed, Jan 25, 2023 at 11:02:26AM -0800, Jakub Kicinski wrote: > > > > On Tue, 24 Jan 2023 13:54:57 +0200 Leon Romanovsky wrote: > > > > > - err = dev->xfrmdev_ops->xdo_dev_policy_add(xp); > > > > > + err = dev->xfrmdev_ops->xdo_dev_policy_add(xp, extack); > > > > > if (err) { > > > > > xdo->dev = NULL; > > > > > xdo->real_dev = NULL; > > > > > xdo->type = XFRM_DEV_OFFLOAD_UNSPECIFIED; > > > > > xdo->dir = 0; > > > > > netdev_put(dev, &xdo->dev_tracker); > > > > > - NL_SET_ERR_MSG(extack, "Device failed to offload this policy"); > > > > > > > > In a handful of places we do: > > > > > > > > if (!extack->msg) > > > > NL_SET_ERR_MSG(extack, "Device failed to offload this policy"); > > > > > > > > in case the device did not provide the extack. > > > > Dunno if it's worth doing here. > > > > > > Honestly, I followed devlink.c which didn't do that, but looked again > > > and found that devlink can potentially overwrite messages :) > > > > > > For example in this case: > > > 997 err = ops->port_fn_state_get(port, &state, &opstate, extack); > > > 998 if (err) { > > > 999 if (err == -EOPNOTSUPP) > > > 1000 return 0; > > > 1001 return err; > > > 1002 } > > > 1003 if (!devlink_port_fn_state_valid(state)) { > > > 1004 WARN_ON_ONCE(1); > > > 1005 NL_SET_ERR_MSG_MOD(extack, "Invalid state read from driver"); > > > 1006 return -EINVAL; > > > 1007 } > > > > > > > > > So what do you think about the following change, so we can leave > > > NL_SET_ERR_MSG_MOD() in devlink and xfrm intact? > > > > > > diff --git a/include/linux/netlink.h b/include/linux/netlink.h > > > index 38f6334f408c..d6f3a958e30b 100644 > > > --- a/include/linux/netlink.h > > > +++ b/include/linux/netlink.h > > > @@ -101,7 +101,7 @@ struct netlink_ext_ack { > > > \ > > > do_trace_netlink_extack(__msg); \ > > > \ > > > - if (__extack) \ > > > + if (__extack && !__extack->msg) \ > > > __extack->_msg = __msg; \ > > > } while (0) > > > > > > @@ -111,7 +111,7 @@ struct netlink_ext_ack { > > > #define NL_SET_ERR_MSG_FMT(extack, fmt, args...) do { \ > > > struct netlink_ext_ack *__extack = (extack); \ > > > \ > > > - if (!__extack) \ > > > + if (!__extack || __extack->msg) \ > > > break; \ > > > if (snprintf(__extack->_msg_buf, NETLINK_MAX_FMTMSG_LEN, \ > > > "%s" fmt "%s", "", ##args, "") >= \ > > > > > > > I think it makes sense. With the above patch 3/10 should be updated to > > preserve the 'catch-all' error message, I guess. > > Great, thanks > > > > > Let's see what Jakub thinks ;) https://lore.kernel.org/netdev/2919eb55e2e9b92265a3ba600afc8137a901ae5f.1674760340.git.leon@kernel.org/T/#u > > > > Cheers, > > > > Paolo > >