From: Andrew Lunn <andrew@lunn.ch>
To: Chris Healy <cphealy@gmail.com>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
neil.armstrong@linaro.org, khilman@baylibre.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
jeremy.wang@amlogic.com, Chris Healy <healych@amazon.com>
Subject: Re: [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD register access
Date: Sun, 29 Jan 2023 17:51:57 +0100 [thread overview]
Message-ID: <Y9akLWJfigajMuQP@lunn.ch> (raw)
In-Reply-To: <20230129022615.379711-1-cphealy@gmail.com>
On Sat, Jan 28, 2023 at 06:26:15PM -0800, Chris Healy wrote:
> From: Chris Healy <healych@amazon.com>
>
> The Meson G12A Internal PHY does not support standard IEEE MMD extended
> register access, therefore add generic dummy stubs to fail the read and
> write MMD calls. This is necessary to prevent the core PHY code from
> erroneously believing that EEE is supported by this PHY even though this
> PHY does not support EEE, as MMD register access returns all FFFFs.
Hi Chris
This change in itself makes sense. But i wounder if we should also
change phy_init_eee(). It reads the EEE Ability register. The 2018
version of the standard indicates the top two bits are reserved and
should be zero. We also don't have any PHY which supports 100GBase-R
through to 100Base-TX. So a read of 0xffff suggests the PHY does not
support EEE and returning -EPROTONOSUPPORT would be good.
Andrew
next prev parent reply other threads:[~2023-01-29 16:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 2:26 [PATCH 1/1] net: phy: meson-gxl: Add generic dummy stubs for MMD register access Chris Healy
2023-01-29 10:26 ` Heiner Kallweit
2023-01-29 21:25 ` Chris Healy
2023-01-29 16:51 ` Andrew Lunn [this message]
2023-01-29 21:28 ` Chris Healy
2023-01-29 21:53 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9akLWJfigajMuQP@lunn.ch \
--to=andrew@lunn.ch \
--cc=cphealy@gmail.com \
--cc=davem@davemloft.net \
--cc=healych@amazon.com \
--cc=hkallweit1@gmail.com \
--cc=jeremy.wang@amlogic.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=neil.armstrong@linaro.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).