* [PATCH] net: tulip: Fix a typo ("defualt")
@ 2023-01-29 15:40 Jonathan Neuschäfer
2023-01-29 18:35 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Neuschäfer @ 2023-01-29 15:40 UTC (permalink / raw)
To: netdev
Cc: Jonathan Neuschäfer, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-parisc, linux-kernel
Spell it as "default".
Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
---
drivers/net/ethernet/dec/tulip/tulip.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/dec/tulip/tulip.h b/drivers/net/ethernet/dec/tulip/tulip.h
index 0ed598dc7569c..0aed3a1d8fe4b 100644
--- a/drivers/net/ethernet/dec/tulip/tulip.h
+++ b/drivers/net/ethernet/dec/tulip/tulip.h
@@ -250,7 +250,7 @@ enum t21143_csr6_bits {
csr6_ttm = (1<<22), /* Transmit Threshold Mode, set for 10baseT, 0 for 100BaseTX */
csr6_sf = (1<<21), /* Store and forward. If set ignores TR bits */
csr6_hbd = (1<<19), /* Heart beat disable. Disables SQE function in 10baseT */
- csr6_ps = (1<<18), /* Port Select. 0 (defualt) = 10baseT, 1 = 100baseTX: can't be set */
+ csr6_ps = (1<<18), /* Port Select. 0 (default) = 10baseT, 1 = 100baseTX: can't be set */
csr6_ca = (1<<17), /* Collision Offset Enable. If set uses special algorithm in low collision situations */
csr6_trh = (1<<15), /* Transmit Threshold high bit */
csr6_trl = (1<<14), /* Transmit Threshold low bit */
--
2.39.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: tulip: Fix a typo ("defualt")
2023-01-29 15:40 [PATCH] net: tulip: Fix a typo ("defualt") Jonathan Neuschäfer
@ 2023-01-29 18:35 ` Simon Horman
2023-01-29 19:47 ` Jonathan Neuschäfer
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2023-01-29 18:35 UTC (permalink / raw)
To: Jonathan Neuschäfer
Cc: netdev, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, linux-parisc, linux-kernel
On Sun, Jan 29, 2023 at 04:40:05PM +0100, Jonathan Neuschäfer wrote:
> Spell it as "default".
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Looks good :)
There also seems to be a misspelling of heartbeat (as hearbeat) on line 277.
Perhaps it would be good to fix that at the same time?
> ---
> drivers/net/ethernet/dec/tulip/tulip.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h b/drivers/net/ethernet/dec/tulip/tulip.h
> index 0ed598dc7569c..0aed3a1d8fe4b 100644
> --- a/drivers/net/ethernet/dec/tulip/tulip.h
> +++ b/drivers/net/ethernet/dec/tulip/tulip.h
> @@ -250,7 +250,7 @@ enum t21143_csr6_bits {
> csr6_ttm = (1<<22), /* Transmit Threshold Mode, set for 10baseT, 0 for 100BaseTX */
> csr6_sf = (1<<21), /* Store and forward. If set ignores TR bits */
> csr6_hbd = (1<<19), /* Heart beat disable. Disables SQE function in 10baseT */
> - csr6_ps = (1<<18), /* Port Select. 0 (defualt) = 10baseT, 1 = 100baseTX: can't be set */
> + csr6_ps = (1<<18), /* Port Select. 0 (default) = 10baseT, 1 = 100baseTX: can't be set */
> csr6_ca = (1<<17), /* Collision Offset Enable. If set uses special algorithm in low collision situations */
> csr6_trh = (1<<15), /* Transmit Threshold high bit */
> csr6_trl = (1<<14), /* Transmit Threshold low bit */
> --
> 2.39.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: tulip: Fix a typo ("defualt")
2023-01-29 18:35 ` Simon Horman
@ 2023-01-29 19:47 ` Jonathan Neuschäfer
0 siblings, 0 replies; 3+ messages in thread
From: Jonathan Neuschäfer @ 2023-01-29 19:47 UTC (permalink / raw)
To: Simon Horman
Cc: Jonathan Neuschäfer, netdev, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-parisc, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On Sun, Jan 29, 2023 at 07:35:15PM +0100, Simon Horman wrote:
> On Sun, Jan 29, 2023 at 04:40:05PM +0100, Jonathan Neuschäfer wrote:
> > Spell it as "default".
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>
> Looks good :)
>
> There also seems to be a misspelling of heartbeat (as hearbeat) on line 277.
> Perhaps it would be good to fix that at the same time?
Sounds good, I'll spin a v2.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-01-29 19:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-01-29 15:40 [PATCH] net: tulip: Fix a typo ("defualt") Jonathan Neuschäfer
2023-01-29 18:35 ` Simon Horman
2023-01-29 19:47 ` Jonathan Neuschäfer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).