From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Жандарович Никита Игоревич" <n.zhandarovich@fintech.ru>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
Felix Fietkau <nbd@nbd.name>,
Lorenzo Bianconi <lorenzo.bianconi83@gmail.com>,
Ryder Lee <ryder.lee@mediatek.com>,
Kalle Valo <kvalo@codeaurora.org>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alexey Khoroshilov <khoroshilov@ispras.ru>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>
Subject: Re: [PATCH 5.10 1/1] mt76: fix mt7615_init_tx_queues() return value
Date: Mon, 30 Jan 2023 14:37:26 +0100 [thread overview]
Message-ID: <Y9fIFirNHNP06e1L@kroah.com> (raw)
In-Reply-To: <b945bd5f3d414ac5bc589d65cf439f7b@fintech.ru>
On Mon, Jan 30, 2023 at 01:27:26PM +0000, Жандарович Никита Игоревич wrote:
> > What is the git commit id of this upstream?
> >
> > And I can't apply this as-is for the obvious reason it would mess up the
> > changelog, how did you create this?
> >
> > confused,
> >
> > greg k-h
>
> Commit in question is b671da33d1c5973f90f098ff66a91953691df582
> upstream. I wasn't certain it makes sense to backport the whole patch
> as only a small portion of it pertains to the fault at question.
What is the "fault"?
And why not take the whole thing? What's wrong with that? We almost
always want to take whatever is in Linus's tree because when we do not,
we almost always cause bugs or other problems (later merge issues.)
So always take the original fix please.
thanks,
greg k-h
next prev parent reply other threads:[~2023-01-30 13:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 12:36 [PATCH 5.10 0/1] mt76: fix mt7615_init_tx_queues() return value Nikita Zhandarovich
2023-01-30 12:36 ` [PATCH 5.10 1/1] " Nikita Zhandarovich
2023-01-30 13:05 ` Greg Kroah-Hartman
2023-01-30 13:27 ` Жандарович Никита Игоревич
2023-01-30 13:37 ` Greg Kroah-Hartman [this message]
2023-01-30 13:48 ` Жандарович Никита Игоревич
2023-01-30 14:01 ` Greg Kroah-Hartman
2023-01-30 16:13 ` Жандарович Никита Игоревич
2023-01-30 16:27 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9fIFirNHNP06e1L@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=khoroshilov@ispras.ru \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi83@gmail.com \
--cc=lvc-project@linuxtesting.org \
--cc=n.zhandarovich@fintech.ru \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).