From: Brian Masney <bmasney@redhat.com>
To: Steev Klimaszewski <steev@kali.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Sven Peter <sven@svenpeter.dev>,
Balakrishna Godavarthi <bgodavar@codeaurora.org>,
Rocky Liao <rjliao@codeaurora.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-bluetooth@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sc8280xp: Enable BT
Date: Mon, 30 Jan 2023 13:35:32 -0500 [thread overview]
Message-ID: <Y9gN9IKAr6y3xzh7@x1> (raw)
In-Reply-To: <20230129215136.5557-4-steev@kali.org>
On Sun, Jan 29, 2023 at 03:51:29PM -0600, Steev Klimaszewski wrote:
> From: Bjorn Andersson <bjorn.andersson@linaro.org>
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
You should also add your Signed-off-by. Also the title of the patch
should be updated to say define uart2 instead of enable BT.
> ---
> arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 122afa03bb40..2d98687fb1ea 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -1244,6 +1244,20 @@ spi3: spi@98c000 {
> status = "disabled";
> };
>
> + uart2: serial@988000 {
This node needs to go after spi2 instead of spi3.
Everything else looks good to me.
Brian
next prev parent reply other threads:[~2023-01-30 18:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 21:51 [PATCH 0/4] Attempt at adding WCN6855 BT support Steev Klimaszewski
2023-01-29 21:51 ` [PATCH 1/4] dt-bindings: net: Add WCN6855 Bluetooth bindings Steev Klimaszewski
2023-01-29 21:51 ` [PATCH 2/4] Bluetooth: hci_qca: Add support for QTI Bluetooth chip wcn6855 Steev Klimaszewski
2023-01-29 21:51 ` [PATCH 3/4] arm64: dts: qcom: sc8280xp: Enable BT Steev Klimaszewski
2023-01-29 21:51 ` [PATCH 4/4] arm64: dts: qcom: thinkpad-x13s: Add bluetooth Steev Klimaszewski
2023-01-30 18:35 ` Brian Masney [this message]
2023-01-30 22:23 ` [PATCH 1/4] dt-bindings: net: Add WCN6855 Bluetooth bindings Rob Herring
2023-01-31 2:21 ` Steev Klimaszewski
2023-01-30 6:43 ` [PATCH 0/4] Attempt at adding WCN6855 BT support Paul Menzel
2023-01-30 6:53 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9gN9IKAr6y3xzh7@x1 \
--to=bmasney@redhat.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bgodavar@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=johan.hedberg@gmail.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rjliao@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=steev@kali.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).