From: Leon Romanovsky <leon@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, jacob.e.keller@intel.com
Subject: Re: [patch net-next 2/3] devlink: remove "gen" from struct devlink_gen_cmd name
Date: Tue, 31 Jan 2023 13:57:56 +0200 [thread overview]
Message-ID: <Y9kCRK2NNnwClq+Z@unreal> (raw)
In-Reply-To: <Y9kBbPdGYN8awqVX@nanopsycho>
On Tue, Jan 31, 2023 at 12:54:20PM +0100, Jiri Pirko wrote:
> Tue, Jan 31, 2023 at 12:51:47PM CET, leon@kernel.org wrote:
> >On Tue, Jan 31, 2023 at 10:06:12AM +0100, Jiri Pirko wrote:
> >> From: Jiri Pirko <jiri@nvidia.com>
> >>
> >> No need to have "gen" inside name of the structure for devlink commands.
> >> Remove it.
> >
> >And what about devl_gen_* names? Should they be renamed too?
>
> Yep, see the next patch :)
Ohh, I would organize them differently.
Thanks
next prev parent reply other threads:[~2023-01-31 11:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 9:06 [patch net-next 0/3] devlink: trivial names cleanup Jiri Pirko
2023-01-31 9:06 ` [patch net-next 1/3] devlink: rename devlink_nl_instance_iter_dump() to "dumpit" Jiri Pirko
2023-01-31 18:31 ` Jacob Keller
2023-01-31 9:06 ` [patch net-next 2/3] devlink: remove "gen" from struct devlink_gen_cmd name Jiri Pirko
2023-01-31 11:51 ` Leon Romanovsky
2023-01-31 11:54 ` Jiri Pirko
2023-01-31 11:57 ` Leon Romanovsky [this message]
2023-01-31 12:08 ` Jiri Pirko
2023-01-31 9:06 ` [patch net-next 3/3] devlink: rename and reorder instances of struct devlink_cmd Jiri Pirko
2023-01-31 11:58 ` [patch net-next 0/3] devlink: trivial names cleanup Leon Romanovsky
2023-01-31 18:32 ` Jacob Keller
2023-02-01 5:18 ` Jakub Kicinski
2023-02-01 12:10 ` Jiri Pirko
2023-02-01 19:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9kCRK2NNnwClq+Z@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).