From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22824C38142 for ; Tue, 31 Jan 2023 11:58:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230193AbjAaL6H (ORCPT ); Tue, 31 Jan 2023 06:58:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230007AbjAaL6F (ORCPT ); Tue, 31 Jan 2023 06:58:05 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73D5029E03 for ; Tue, 31 Jan 2023 03:58:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 26F0DB81BF7 for ; Tue, 31 Jan 2023 11:58:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5C049C433D2; Tue, 31 Jan 2023 11:58:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675166280; bh=/IKKY62jNocNp42l2ZkQRkhINaQ+YxN+5s1gQtHE8og=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SPSJGuYAVxsxg+gJklWoqHoh+q5mHY3g3ZqfCOyRXBHwrO+I6MOpnulcXa/IOi9n+ tarDOGWLtymuNlgvvZPE1CVJaEXrac3EnXE17/z4siIujq/2OLJEPyPzYNhK5TEmJf rMRMX9Ujd66w6DkyslNdDPT+9KAt4jLZEJSSB4ampOXD/4pB8XSkCorWsmBHd5lczf d7aPqSNiHP351IM3A6ayoXecQtRHbOcI8p8T+Etz9BleIijczZGp5CwWIjIfPIuksa vTDYowAGY7RAefwAcL2A9rFCeAOuSvon+lsBFsdHosKEaCZkH23W5gggTWQ3LofG88 QX/OrZKIPXH6A== Date: Tue, 31 Jan 2023 13:57:56 +0200 From: Leon Romanovsky To: Jiri Pirko Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, jacob.e.keller@intel.com Subject: Re: [patch net-next 2/3] devlink: remove "gen" from struct devlink_gen_cmd name Message-ID: References: <20230131090613.2131740-1-jiri@resnulli.us> <20230131090613.2131740-3-jiri@resnulli.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 31, 2023 at 12:54:20PM +0100, Jiri Pirko wrote: > Tue, Jan 31, 2023 at 12:51:47PM CET, leon@kernel.org wrote: > >On Tue, Jan 31, 2023 at 10:06:12AM +0100, Jiri Pirko wrote: > >> From: Jiri Pirko > >> > >> No need to have "gen" inside name of the structure for devlink commands. > >> Remove it. > > > >And what about devl_gen_* names? Should they be renamed too? > > Yep, see the next patch :) Ohh, I would organize them differently. Thanks