netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: "Frank.Sae" <Frank.Sae@motor-comm.com>
Cc: Rob Herring <robh@kernel.org>, Peter Geis <pgwipeout@gmail.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	yanhong.wang@starfivetech.com, xiaogang.fan@motor-comm.com,
	fei.zhang@motor-comm.com, hua.sun@motor-comm.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v3 1/5] dt-bindings: net: Add Motorcomm yt8xxx ethernet phy
Date: Tue, 31 Jan 2023 14:33:18 +0100	[thread overview]
Message-ID: <Y9kYnnYRMW9Vi0DU@lunn.ch> (raw)
In-Reply-To: <af6beebc-0a70-16f5-e0e9-5f4cbeea8955@motor-comm.com>

> phy id list:
> YT8511	0x0000010a
> YT8521	0x0000011A
> YT8531  0x4f51e91b

The first two are clearly invalid, the OUI part is zero. So i would
not list those. Just use the last one.

In the binding part, you need something like

properties:
  compatible:
    const: ethernet-phy-id4f51.e91b
    description: Only needed for DT lint tools

What i don't know is how this will work in combination with the
compatibles gained from ethernet-phy.yaml. You might need to follow
the same structure, include a oneOf:

In the example part, you would do something like:
> 
>     mdio0 {
>         ...
>         ethernet-phy@5 {
	      # Only needed to make DT lint tools work. Do not copy/paste
	      # into real DTS files.
>             compatible = "ethernet-phy-id4f51.e91b";
>             reg = <5>;
>             ...
>         };
>     };

I don't think there are any examples to follow because the kernel
does not need any of this, is probes using the IDs. Listing
compatibles like this is purely for the DT tools, which is why i put
in the comments about not copy/pasting it to real DT blobs.

   Andrew

  reply	other threads:[~2023-01-31 13:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30  6:35 [PATCH net-next v3 0/5] add dts for yt8521 and yt8531s, add driver for yt8531 Frank Sae
2023-01-30  6:35 ` [PATCH net-next v3 1/5] dt-bindings: net: Add Motorcomm yt8xxx ethernet phy Frank Sae
2023-01-30 14:03   ` Andrew Lunn
2023-01-31  2:21     ` Frank.Sae
2023-01-31 13:42       ` Andrew Lunn
2023-01-30 22:41   ` Rob Herring
2023-01-31  3:19     ` Frank.Sae
2023-01-31 13:33       ` Andrew Lunn [this message]
2023-01-31 18:56   ` Krzysztof Kozlowski
2023-01-30  6:35 ` [PATCH net-next v3 2/5] net: phy: Add BIT macro for Motorcomm yt8521/yt8531 gigabit " Frank Sae
2023-01-30  6:35 ` [PATCH net-next v3 3/5] net: phy: Add dts support for Motorcomm yt8521 " Frank Sae
2023-01-30  6:35 ` [PATCH net-next v3 4/5] net: phy: Add dts support for Motorcomm yt8531s " Frank Sae
2023-01-30  6:35 ` [PATCH net-next v3 5/5] net: phy: Add driver for Motorcomm yt8531 " Frank Sae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y9kYnnYRMW9Vi0DU@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Frank.Sae@motor-comm.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=fei.zhang@motor-comm.com \
    --cc=hkallweit1@gmail.com \
    --cc=hua.sun@motor-comm.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pgwipeout@gmail.com \
    --cc=robh@kernel.org \
    --cc=xiaogang.fan@motor-comm.com \
    --cc=yanhong.wang@starfivetech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).