From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Michael Walle <michael@walle.cc>
Cc: Andrew Lunn <andrew@lunn.ch>, Jiri Pirko <jiri@resnulli.us>,
Jakub Kicinski <kuba@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org, Keller Jacob E <jacob.e.keller@intel.com>
Subject: Re: PHY firmware update method
Date: Tue, 31 Jan 2023 16:29:04 +0000 [thread overview]
Message-ID: <Y9lB0MmgyCZxnk3N@shell.armlinux.org.uk> (raw)
In-Reply-To: <7bd02bf6880a092b64a0c27d3715f5b6@walle.cc>
On Tue, Jan 31, 2023 at 05:10:08PM +0100, Michael Walle wrote:
> Am 2023-01-24 21:42, schrieb Andrew Lunn:
> > One device being slow to probe will slow down the probe of that
> > bus. But probe of other busses should be unaffected. I _guess_ it
> > might have a global affect on EPROBE_DEFER, the next cycle could be
> > delayed? Probably a question for GregKH, or reading the code.
> >
> > If it going to be really slow, then i would suggest making use of
> > devlink and it being a user initiated operation.
>
> One concern which raised internally was that you'll always do
> the update (unconditionally) if there is a newer version. You seem
> to make life easier for the user, because the update just runs
> automatically. OTHO, what if a user doesn't want to update (for
> whatever reason) to the particular version in linux-firmware.git.
> I'm undecided on that.
On one hand, the user should always be asked whether they want to
upgrade the firmware on their systems, but there is the argument
about whether a user has sufficient information to make an informed
choice about it.
Then there's the problem that a newer firmware might introduce a
bug, but the user wants to use an older version (which is something
I do with some WiFi setups, and it becomes a pain when linux-firmware
is maintained by the distro, but you don't want to use that provided
version.
I really don't like the idea of the kernel automatically updating
non-volatile firmware - that sounds to me like a recipe for all
sorts of disasters.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-01-31 16:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 11:27 PHY firmware update method Michael Walle
2022-09-28 12:28 ` Andrew Lunn
2022-09-29 7:04 ` Jiri Pirko
2022-09-29 12:28 ` Andrew Lunn
2022-09-29 14:12 ` Jakub Kicinski
2022-09-29 14:53 ` Andrew Lunn
2022-09-30 8:25 ` Jiri Pirko
2022-09-30 12:36 ` Andrew Lunn
2022-09-30 14:45 ` Jakub Kicinski
2022-09-30 16:49 ` Keller, Jacob E
2022-10-03 12:18 ` Russell King (Oracle)
2022-10-03 14:42 ` Jakub Kicinski
2022-10-03 17:53 ` Keller, Jacob E
2022-10-03 18:04 ` Jacob Keller
2023-01-24 17:13 ` Michael Walle
2023-01-24 17:11 ` Michael Walle
2023-01-24 20:42 ` Andrew Lunn
2023-01-31 16:10 ` Michael Walle
2023-01-31 16:29 ` Russell King (Oracle) [this message]
2023-01-31 17:48 ` Michael Walle
2023-01-31 18:36 ` Jacob Keller
2023-01-31 18:41 ` Jakub Kicinski
2023-01-31 19:56 ` Jacob Keller
2023-01-31 21:07 ` Jakub Kicinski
2023-01-24 22:28 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9lB0MmgyCZxnk3N@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=hkallweit1@gmail.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=michael@walle.cc \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).