From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Simon Horman <simon.horman@corigine.com>,
David Miller <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, oss-drivers@corigine.com,
Yanguo Li <yanguo.li@corigine.com>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH net] nfp: flower: avoid taking mutex in atomic context
Date: Wed, 1 Feb 2023 10:21:51 +0200 [thread overview]
Message-ID: <Y9ohH58dRgFWx9o4@unreal> (raw)
In-Reply-To: <20230131132129.0d043582@kernel.org>
On Tue, Jan 31, 2023 at 01:21:29PM -0800, Jakub Kicinski wrote:
> On Tue, 31 Jan 2023 15:27:51 +0200 Leon Romanovsky wrote:
> > > > > + if ((port_id & NFP_FL_LAG_OUT) == NFP_FL_LAG_OUT) {
> > > > > + memset(&lag_info, 0, sizeof(struct nfp_tun_neigh_lag));
> > > >
> > > > This memset can be removed if you initialize lag_info to zero.
> > > > struct nfp_tun_neigh_lag lag_info = {};
> > >
> > > Happy to change if that is preferred.
> > > Is it preferred?
> >
> > I don't see why it can't be preferred.
>
> It's too subjective to make Simon respin, IMO.
I'm not insisting on respin, but would like to hear why writing compact
code with cleared variable on stack, which anyway needs to be cleared is
not preferred.
Thanks
next prev parent reply other threads:[~2023-02-01 8:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 8:03 [PATCH net] nfp: flower: avoid taking mutex in atomic context Simon Horman
2023-01-31 11:45 ` Leon Romanovsky
2023-01-31 12:15 ` Simon Horman
2023-01-31 13:27 ` Leon Romanovsky
2023-01-31 21:21 ` Jakub Kicinski
2023-02-01 8:21 ` Leon Romanovsky [this message]
2023-02-02 4:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9ohH58dRgFWx9o4@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=error27@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=yanguo.li@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).