From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6305BC05027 for ; Thu, 2 Feb 2023 08:46:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229851AbjBBIqo (ORCPT ); Thu, 2 Feb 2023 03:46:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59098 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229546AbjBBIqn (ORCPT ); Thu, 2 Feb 2023 03:46:43 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 954FE86613 for ; Thu, 2 Feb 2023 00:46:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3BE3061A27 for ; Thu, 2 Feb 2023 08:46:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27803C433D2; Thu, 2 Feb 2023 08:46:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675327601; bh=jfE/ej7TVMEwkfa2/ThlszqLjPC9r6H4LeMVWvGJrAo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lOvyZaF+zUPYwi6vzEIM0KGaKbD716B4eWY7AV04Av+8dUW9YfW2RfER+T1KpCWHx 8DHgRjoWPugssoHLwW8sQ30LWmwGy/XFA9+50jomgoXNaLJKSAkSxkNlbCStIEjsVn 6p8/e0YuF0Uyuuz1IYYuhlbc25LgThCeg0aFIGgUnb4tJ1igqC3OvzbfRrgMWnbSJp ay91wTq2GzubFpVUTssFQoHEtgOx8MPlFai6Ce4SuFiCKyHRBMkk9frhtaD2hP2sCM nJNAyF0qwgEalhysPDCIcYLaSqkkgYXrrdzAX3jnuZwjakf5A/8ORDr+OglFAwtoQw XBOJoNGIwvMwg== Date: Thu, 2 Feb 2023 10:46:37 +0200 From: Leon Romanovsky To: Shannon Nelson Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, drivers@pensando.io Subject: Re: [PATCH net 5/6] ionic: clear up notifyq alloc commentary Message-ID: References: <20230202013002.34358-1-shannon.nelson@amd.com> <20230202013002.34358-6-shannon.nelson@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230202013002.34358-6-shannon.nelson@amd.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 01, 2023 at 05:30:01PM -0800, Shannon Nelson wrote: > Make sure the q+cq alloc for NotifyQ is clearly documented > and don't bother with unnecessary local variables. > > Signed-off-by: Shannon Nelson > --- > drivers/net/ethernet/pensando/ionic/ionic_lif.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky