From: Jiri Pirko <jiri@resnulli.us>
To: "陶 缘" <taoyuan_eddy@hotmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Pravin B Shelar <pshelar@ovn.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"dev@openvswitch.org" <dev@openvswitch.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: 回复: [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used_mask memory
Date: Fri, 3 Feb 2023 12:55:26 +0100 [thread overview]
Message-ID: <Y9z2Lk+VvAHgu/4r@nanopsycho> (raw)
In-Reply-To: <OS3P286MB2295466ADE3312A2B9C02C51F5D79@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM>
Fri, Feb 03, 2023 at 10:03:28AM CET, taoyuan_eddy@hotmail.com wrote:
>sorry, Jiri, my bad, will hold on before the next submission/hope it is the final one
Don't top-post please. So what is the change comparing to v4?
>
>eddy
>________________________________
>发件人: Jiri Pirko <jiri@resnulli.us>
>发送时间: 2023年2月3日 9:00
>收件人: Eddy Tao <taoyuan_eddy@hotmail.com>
>抄送: netdev@vger.kernel.org <netdev@vger.kernel.org>; Pravin B Shelar <pshelar@ovn.org>; David S. Miller <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; dev@openvswitch.org <dev@openvswitch.org>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>
>主题: Re: [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used_mask memory
>
>Fri, Feb 03, 2023 at 09:52:56AM CET, taoyuan_eddy@hotmail.com wrote:
>>Use actual CPU number instead of hardcoded value to decide the size
>>of 'cpu_used_mask' in 'struct sw_flow'. Below is the reason.
>>
>>'struct cpumask cpu_used_mask' is embedded in struct sw_flow.
>>Its size is hardcoded to CONFIG_NR_CPUS bits, which can be
>>8192 by default, it costs memory and slows down ovs_flow_alloc
>>
>>To address this, redefine cpu_used_mask to pointer
>>append cpumask_size() bytes after 'stat' to hold cpumask
>>
>>cpumask APIs like cpumask_next and cpumask_set_cpu never access
>>bits beyond cpu count, cpumask_size() bytes of memory is enough
>>
>>Signed-off-by: Eddy Tao <taoyuan_eddy@hotmail.com>
>
>Eddy, could you please slow down a bit? Why did you send v5 right
>after v4? Could you please always put a changelog to the patch
>submitted to contain info about changes in between the
>submitted version?
>
>Thanks!
>
prev parent reply other threads:[~2023-02-03 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 8:52 [PATCH net-next v5 1/1] net:openvswitch:reduce cpu_used_mask memory Eddy Tao
2023-02-03 9:00 ` Jiri Pirko
[not found] ` <OS3P286MB2295466ADE3312A2B9C02C51F5D79@OS3P286MB2295.JPNP286.PROD.OUTLOOK.COM>
2023-02-03 11:55 ` Jiri Pirko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9z2Lk+VvAHgu/4r@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pshelar@ovn.org \
--cc=taoyuan_eddy@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox