From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35782C433DB for ; Thu, 14 Jan 2021 15:45:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0681723A9F for ; Thu, 14 Jan 2021 15:45:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729173AbhANPp0 (ORCPT ); Thu, 14 Jan 2021 10:45:26 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:40792 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727335AbhANPp0 (ORCPT ); Thu, 14 Jan 2021 10:45:26 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l04nc-000a2B-Qo; Thu, 14 Jan 2021 16:44:36 +0100 Date: Thu, 14 Jan 2021 16:44:36 +0100 From: Andrew Lunn To: stefanc@marvell.com Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com, linux-kernel@vger.kernel.org, kuba@kernel.org, linux@armlinux.org.uk, mw@semihalf.com, rmk+kernel@armlinux.org.uk, atenart@kernel.org Subject: Re: [PATCH net-next] net: mvpp2: extend mib-fragments name to mib-fragments-err Message-ID: References: <1610618858-5093-1-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610618858-5093-1-git-send-email-stefanc@marvell.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jan 14, 2021 at 12:07:38PM +0200, stefanc@marvell.com wrote: > From: Stefan Chulski > > This patch doesn't change any functionality, but just extend > MIB counter register and ethtool-statistic names with "err". > > The counter MVPP2_MIB_FRAGMENTS_RCVD in fact is Error counter. > Extend REG name and appropriated ethtool statistic reg-name > with the ERR/err. > --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c > @@ -1566,7 +1566,7 @@ static u32 mvpp2_read_index(struct mvpp2 *priv, u32 index, u32 reg) > { MVPP2_MIB_FC_RCVD, "fc_received" }, > { MVPP2_MIB_RX_FIFO_OVERRUN, "rx_fifo_overrun" }, > { MVPP2_MIB_UNDERSIZE_RCVD, "undersize_received" }, > - { MVPP2_MIB_FRAGMENTS_RCVD, "fragments_received" }, > + { MVPP2_MIB_FRAGMENTS_ERR_RCVD, "fragments_err_received" }, Hi Stefan I suspect this is now ABI and you cannot change it. You at least need to argue why it is not ABI. Andrew