From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A1BC433E0 for ; Mon, 18 Jan 2021 17:42:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DE55A22CAD for ; Mon, 18 Jan 2021 17:42:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406228AbhARRmJ (ORCPT ); Mon, 18 Jan 2021 12:42:09 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:46382 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2406948AbhARRlt (ORCPT ); Mon, 18 Jan 2021 12:41:49 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l1YWT-001Jap-KO; Mon, 18 Jan 2021 18:41:01 +0100 Date: Mon, 18 Jan 2021 18:41:01 +0100 From: Andrew Lunn To: Tobias Waldekranz Cc: Chris Healy , Marek Behun , netdev Subject: Re: bug: net: dsa: mv88e6xxx: serdes Unable to communicate on fiber with vf610-zii-dev-rev-c Message-ID: References: <20200718164239.40ded692@nic.cz> <20200718150514.GC1375379@lunn.ch> <20200718172244.59576938@nic.cz> <8735yykv88.fsf@waldekranz.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8735yykv88.fsf@waldekranz.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 18, 2021 at 06:31:19PM +0100, Tobias Waldekranz wrote: > On Sun, Jul 19, 2020 at 14:43, Chris Healy wrote: > > On Sat, Jul 18, 2020 at 8:22 AM Marek Behun wrote: > >> > >> On Sat, 18 Jul 2020 17:05:14 +0200 > >> Andrew Lunn wrote: > >> > >> > > If the traces were broken between the fiber module and the SERDES, I > >> > > should not see these counters incrementing. > >> > > >> > Plus it is reproducible on multiple boards, of different designs. > >> > > >> > This is somehow specific to the 6390X ports 9 and 10. > >> > > >> > Andrew > >> > >> Hmm. > >> > >> What about the errata setup? > >> It says: > >> /* The 6390 copper ports have an errata which require poking magic > >> * values into undocumented hidden registers and then performing a > >> * software reset. > >> */ > >> But then the port_hidden_write function is called for every port in the > >> function mv88e6390_setup_errata, not just for copper ports. Maybe Chris > >> should try to not write this hidden register for SerDes ports. > > > > I just disabled the mv88e6390_setup_errata all together and this did > > not result in any different behaviour on this broken fiber port. > > Hi Chris, > > Did you manage to track this down? > > I am seeing the exact same issue. I have tried both a 1000base-x SFP and > a copper 1000base-T and get the same result on both - transmit is fine > but rx only works up to the SERDES, no rx MAC counters are moving. Hi Tobias We never tracked this down. I spent many hours bashing my head against this. I could not bisect it, which did not help. FYI: Chris has moved onto a new job, and is unlikely to be involved with Marvell switches any more. Andrew