From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFB07C433E6 for ; Thu, 28 Jan 2021 01:00:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9C0EC64DD1 for ; Thu, 28 Jan 2021 01:00:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231181AbhA1A7p (ORCPT ); Wed, 27 Jan 2021 19:59:45 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:35354 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231356AbhA1A5Y (ORCPT ); Wed, 27 Jan 2021 19:57:24 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1l4vbt-002x2k-UC; Thu, 28 Jan 2021 01:56:33 +0100 Date: Thu, 28 Jan 2021 01:56:33 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: "David S . Miller" , Jakub Kicinski , netdev@vger.kernel.org, Florian Fainelli , Vivien Didelot , Hideaki YOSHIFUJI Subject: Re: [PATCH net-next 4/4] Revert "net: ipv4: handle DSA enabled master network devices" Message-ID: References: <20210127010028.1619443-1-olteanv@gmail.com> <20210127010028.1619443-5-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210127010028.1619443-5-olteanv@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 27, 2021 at 03:00:28AM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > This reverts commit 728c02089a0e3eefb02e9927bfae50490f40e72e. > > Since 2015 DSA has gained more integration with the network stack, we > can now have the same functionality without explicitly open-coding for > it: > - It now opens the DSA master netdevice automatically whenever a user > netdevice is opened. > - The master and switch interfaces are coupled in an upper/lower > hierarchy using the netdev adjacency lists. > > In the nfsroot example below, the interface chosen by autoconfig was > swp3, and every interface except that and the DSA master, eth1, was > brought down afterwards: > > [ 8.714215] mscc_felix 0000:00:00.5 swp0 (uninitialized): PHY [0000:00:00.3:10] driver [Microsemi GE VSC8514 SyncE] (irq=POLL) > [ 8.978041] mscc_felix 0000:00:00.5 swp1 (uninitialized): PHY [0000:00:00.3:11] driver [Microsemi GE VSC8514 SyncE] (irq=POLL) > [ 9.246134] mscc_felix 0000:00:00.5 swp2 (uninitialized): PHY [0000:00:00.3:12] driver [Microsemi GE VSC8514 SyncE] (irq=POLL) > [ 9.486203] mscc_felix 0000:00:00.5 swp3 (uninitialized): PHY [0000:00:00.3:13] driver [Microsemi GE VSC8514 SyncE] (irq=POLL) > [ 9.512827] mscc_felix 0000:00:00.5: configuring for fixed/internal link mode > [ 9.521047] mscc_felix 0000:00:00.5: Link is Up - 2.5Gbps/Full - flow control off > [ 9.530382] device eth1 entered promiscuous mode > [ 9.535452] DSA: tree 0 setup > [ 9.539777] printk: console [netcon0] enabled > [ 9.544504] netconsole: network logging started > [ 9.555047] fsl_enetc 0000:00:00.2 eth1: configuring for fixed/internal link mode > [ 9.562790] fsl_enetc 0000:00:00.2 eth1: Link is Up - 1Gbps/Full - flow control off > [ 9.564661] 8021q: adding VLAN 0 to HW filter on device bond0 > [ 9.637681] fsl_enetc 0000:00:00.0 eth0: PHY [0000:00:00.0:02] driver [Qualcomm Atheros AR8031/AR8033] (irq=POLL) > [ 9.655679] fsl_enetc 0000:00:00.0 eth0: configuring for inband/sgmii link mode > [ 9.666611] mscc_felix 0000:00:00.5 swp0: configuring for inband/qsgmii link mode > [ 9.676216] 8021q: adding VLAN 0 to HW filter on device swp0 > [ 9.682086] mscc_felix 0000:00:00.5 swp1: configuring for inband/qsgmii link mode > [ 9.690700] 8021q: adding VLAN 0 to HW filter on device swp1 > [ 9.696538] mscc_felix 0000:00:00.5 swp2: configuring for inband/qsgmii link mode > [ 9.705131] 8021q: adding VLAN 0 to HW filter on device swp2 > [ 9.710964] mscc_felix 0000:00:00.5 swp3: configuring for inband/qsgmii link mode > [ 9.719548] 8021q: adding VLAN 0 to HW filter on device swp3 > [ 9.747811] Sending DHCP requests .. > [ 12.742899] mscc_felix 0000:00:00.5 swp1: Link is Up - 1Gbps/Full - flow control rx/tx > [ 12.743828] mscc_felix 0000:00:00.5 swp0: Link is Up - 1Gbps/Full - flow control off > [ 12.747062] IPv6: ADDRCONF(NETDEV_CHANGE): swp1: link becomes ready > [ 12.755216] fsl_enetc 0000:00:00.0 eth0: Link is Up - 1Gbps/Full - flow control rx/tx > [ 12.766603] IPv6: ADDRCONF(NETDEV_CHANGE): swp0: link becomes ready > [ 12.783188] mscc_felix 0000:00:00.5 swp2: Link is Up - 1Gbps/Full - flow control rx/tx > [ 12.785354] IPv6: ADDRCONF(NETDEV_CHANGE): eth0: link becomes ready > [ 12.799535] IPv6: ADDRCONF(NETDEV_CHANGE): swp2: link becomes ready > [ 13.803141] mscc_felix 0000:00:00.5 swp3: Link is Up - 1Gbps/Full - flow control rx/tx > [ 13.811646] IPv6: ADDRCONF(NETDEV_CHANGE): swp3: link becomes ready > [ 15.452018] ., OK > [ 15.470336] IP-Config: Got DHCP answer from 10.0.0.1, my address is 10.0.0.39 > [ 15.477887] IP-Config: Complete: > [ 15.481330] device=swp3, hwaddr=00:04:9f:05:de:0a, ipaddr=10.0.0.39, mask=255.255.255.0, gw=10.0.0.1 > [ 15.491846] host=10.0.0.39, domain=(none), nis-domain=(none) > [ 15.498429] bootserver=10.0.0.1, rootserver=10.0.0.1, rootpath= > [ 15.498481] nameserver0=8.8.8.8 > [ 15.627542] fsl_enetc 0000:00:00.0 eth0: Link is Down > [ 15.690903] mscc_felix 0000:00:00.5 swp0: Link is Down > [ 15.745216] mscc_felix 0000:00:00.5 swp1: Link is Down > [ 15.800498] mscc_felix 0000:00:00.5 swp2: Link is Down > [ 15.858143] ALSA device list: > [ 15.861420] No soundcards found. > > Signed-off-by: Vladimir Oltean Reviewed-by: Andrew Lunn Andrew