From: Greg KH <gregkh@linuxfoundation.org>
To: Aviraj CJ <acj@cisco.com>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, xe-linux-external@cisco.com,
Hangbin Liu <liuhangbin@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition
Date: Sat, 30 Jan 2021 09:36:12 +0100 [thread overview]
Message-ID: <YBUafB76nbydgXv+@kroah.com> (raw)
In-Reply-To: <20210129192741.117693-1-acj@cisco.com>
On Sat, Jan 30, 2021 at 12:57:40AM +0530, Aviraj CJ wrote:
> From: Hangbin Liu <liuhangbin@gmail.com>
>
> commit b59e286be280fa3c2e94a0716ddcee6ba02bc8ba upstream.
>
> Based on RFC7112, Section 6:
>
> IANA has added the following "Type 4 - Parameter Problem" message to
> the "Internet Control Message Protocol version 6 (ICMPv6) Parameters"
> registry:
>
> CODE NAME/DESCRIPTION
> 3 IPv6 First Fragment has incomplete IPv6 Header Chain
>
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Aviraj CJ <acj@cisco.com>
> ---
> include/uapi/linux/icmpv6.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/uapi/linux/icmpv6.h b/include/uapi/linux/icmpv6.h
> index 2622b5a3e616..9a31ea2ad1cf 100644
> --- a/include/uapi/linux/icmpv6.h
> +++ b/include/uapi/linux/icmpv6.h
> @@ -137,6 +137,7 @@ struct icmp6hdr {
> #define ICMPV6_HDR_FIELD 0
> #define ICMPV6_UNK_NEXTHDR 1
> #define ICMPV6_UNK_OPTION 2
> +#define ICMPV6_HDR_INCOMP 3
>
> /*
> * constants for (set|get)sockopt
> --
> 2.26.2.Cisco
>
What do you mean by "internal review" and what am I supposed to do with
this patch? Same for the 2/2 patch in this series...
thanks,
greg k-h
next prev parent reply other threads:[~2021-01-30 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 19:27 [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition Aviraj CJ
2021-01-29 19:27 ` [Internal review][PATCH stable v5.4 2/2] IPv6: reply ICMP error if the first fragment don't include all headers Aviraj CJ
2021-01-30 8:36 ` Greg KH [this message]
2021-01-30 11:31 ` [Internal review][PATCH stable v5.4 1/2] ICMPv6: Add ICMPv6 Parameter Problem, code 3 definition Aviraj Cj (acj)
2021-01-30 11:51 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBUafB76nbydgXv+@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=acj@cisco.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xe-linux-external@cisco.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).