From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29FABC433E0 for ; Wed, 3 Feb 2021 16:26:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBEBA64F76 for ; Wed, 3 Feb 2021 16:26:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233395AbhBCQ0v (ORCPT ); Wed, 3 Feb 2021 11:26:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbhBCQ0s (ORCPT ); Wed, 3 Feb 2021 11:26:48 -0500 Received: from mail-qt1-x849.google.com (mail-qt1-x849.google.com [IPv6:2607:f8b0:4864:20::849]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85D90C061573 for ; Wed, 3 Feb 2021 08:26:07 -0800 (PST) Received: by mail-qt1-x849.google.com with SMTP id o20so263648qtx.22 for ; Wed, 03 Feb 2021 08:26:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:in-reply-to:message-id:mime-version:references:subject :from:to:cc; bh=EKSWs4oHbdvSr3JCVuE/WyEGXbHNjwSY5+CA0/uAaTo=; b=uVQBMo5xdaLkoYHQL5bDzmVuvyDAP57aUThKL3COMCeMZijVb2z86F5o56RbGkFjhp FyTM1pkIjjVUQV7uvv5JFqtpU0AplVAjyZib0VNxgJ1WYvqIHcNa3BKmTwOt0RRYiv0Q SjG7N0jQFqoy7xVUa+oqb8LEFbNf8camf/Rx3/O5195V7c5FkeI2d3TmezZlRVsXaK6g ZPpJgppm1AmFUblHWjwgo3koH7J3ttgGxYjHYLU0HDW3fcdOhjnfcXAU1JQQglPIKZ0p mM41UYlhr2zEHjqmTvRkQeEnITVvih8pY7e79XF9/aQgAepygbimq0P3HgMPnKKcEovN J06g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=EKSWs4oHbdvSr3JCVuE/WyEGXbHNjwSY5+CA0/uAaTo=; b=gYzdqrazrb1XhgH8ZcBfXdSuQsN7dxVzvJqcRZZTe77b3EDK1RU2TaJzHLTbawKVpw m6/3i+ffrcbJZAXQ8YacjvJG6eYqGRnZPa2aIfVFNVaMmlwa/3hLehWOWIstSMbNVd3Q ez+zSjUp8kPT12ToILzlAVEpxZuhiItgSDQCa0xtJYMktLebHxiar2PzRT31/EdCAmCs dbSnJ9Wb1kWakgG52EiiGKNLEO37G5auoRyTLuU0pm90ZNZZ6uH0pd9qAMQGb6jpbQ07 rHOyHd16HkVTH6qdhnShggVf2SyL00mfrPgk7ToWrRyZEWg0VT6y7nR4YWtHc252mdur evyg== X-Gm-Message-State: AOAM530Szzlu0HWgcZB7VK/g667eboUxK+nQ+TJo0LlmfOIFLIhbXM2E 6Gvl/9B05uYrVyTmq8J05Z9DD28= X-Google-Smtp-Source: ABdhPJztvF9a4haVIw8TdKLDdV8zCJzp3EdeErR+e5syJliNjXlPk6zXgWUSo/JiGmhIINZULbSq084= Sender: "sdf via sendgmr" X-Received: from sdf2.svl.corp.google.com ([2620:15c:2c4:1:f84b:ed96:ea48:8bdb]) (user=sdf job=sendgmr) by 2002:ad4:4993:: with SMTP id t19mr3574360qvx.41.1612369566632; Wed, 03 Feb 2021 08:26:06 -0800 (PST) Date: Wed, 3 Feb 2021 08:26:04 -0800 In-Reply-To: Message-Id: Mime-Version: 1.0 References: <20210129001210.344438-1-hari@netflix.com> <20210201140614.5d73ede0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Subject: Re: [PATCH] net: tracepoint: exposing sk_family in all tcp:tracepoints From: sdf@google.com To: Eric Dumazet Cc: Jakub Kicinski , Hariharan Ananthakrishnan , "David S . Miller" , netdev , Song Liu , Daniel Borkmann , Alexei Starovoitov , Brendan Gregg Content-Type: text/plain; charset="UTF-8"; format=flowed; delsp=yes Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 02/02, Eric Dumazet wrote: > On Mon, Feb 1, 2021 at 11:06 PM Jakub Kicinski wrote: > > > > On Fri, 29 Jan 2021 00:12:10 +0000 Hariharan Ananthakrishnan wrote: > > > Similar to sock:inet_sock_set_state tracepoint, expose sk_family to > > > distinguish AF_INET and AF_INET6 families. > > > > > > The following tcp tracepoints are updated: > > > tcp:tcp_destroy_sock > > > tcp:tcp_rcv_space_adjust > > > tcp:tcp_retransmit_skb > > > tcp:tcp_send_reset > > > tcp:tcp_receive_reset > > > tcp:tcp_retransmit_synack > > > tcp:tcp_probe > > > > > > Signed-off-by: Hariharan Ananthakrishnan > > > Signed-off-by: Brendan Gregg > > > > Eric, any thoughts? > I do not use these tracepoints in production scripts, but I wonder if > existing tools could break after this change ? > Or do we consider tracepoints format is not part of the ABI and can be > arbitrarily changed by anyone ? They are not ABI and since we are extending tracepoints with additional info (and not removing any existing fields) it shouldn't be a problem.