Re: [PATCH] drivers: net: ehternet: i825xx: Fix couple of spellings in the file ether1.c

[Bhaskar Chowdhury <unixbhaskar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2352 bytes --]

On 12:13 Wed 03 Feb 2021, Jakub Kicinski wrote:
>On Wed, 3 Feb 2021 09:54:22 -0800 Randy Dunlap wrote:
>> On 2/3/21 7:15 AM, Bhaskar Chowdhury wrote:
>> >
>> > s/initialsation/initialisation/
>> > s/specifiing/specifying/
>> >
>> > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>
>> Hi,
>>
>> $Subject has a typo/spello.
>
>This happens more than you'd think with spell fixies. Always makes me
>chuckle. FWIW "net: i825xx:" is enough of a prefix, no need to
>transcribe the entire directory path.
>
>> The 2 fixes below look good (as explained in the patch description),
>> but:
>> can you explain the 3 changes below that AFAICT do nothing?
>

I am so sorry that error like this lean in . I will fix that Randy..thank
you...
>I think we can jump to the conclusion that Bhaskar's editor cleanup up
>trailing white space.
>
>Bhaskar please make sure that the patch does not make unrelated white
>space changes.
>
>> >  drivers/net/ethernet/i825xx/ether1.c | 10 +++++-----
>> >  1 file changed, 5 insertions(+), 5 deletions(-)
>> >
>> > diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
>> > index a0bfb509e002..0233fb6e222d 100644
>> > --- a/drivers/net/ethernet/i825xx/ether1.c
>> > +++ b/drivers/net/ethernet/i825xx/ether1.c
>> > @@ -885,7 +885,7 @@ ether1_recv_done (struct net_device *dev)
>> >  		ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_command, NORMALIRQS);
>> >  		ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_status, NORMALIRQS);
>> >  		ether1_writew(dev, 0, priv(dev)->rx_tail, rfd_t, rfd_rbdoffset, NORMALIRQS);
>> > -
>> > +
>> >  		priv(dev)->rx_tail = nexttail;
>> >  		priv(dev)->rx_head = ether1_readw(dev, priv(dev)->rx_head, rfd_t, rfd_link, NORMALIRQS);
>> >  	} while (1);
>> > @@ -1031,7 +1031,7 @@ ether1_probe(struct expansion_card *ec, const struct ecard_id *id)
>> >
>> >  	printk(KERN_INFO "%s: ether1 in slot %d, %pM\n",
>> >  		dev->name, ec->slot_no, dev->dev_addr);
>> > -
>> > +
>> >  	ecard_set_drvdata(ec, dev);
>> >  	return 0;
>> >
>> > @@ -1047,7 +1047,7 @@ static void ether1_remove(struct expansion_card *ec)
>> >  {
>> >  	struct net_device *dev = ecard_get_drvdata(ec);
>> >
>> > -	ecard_set_drvdata(ec, NULL);
>> > +	ecard_set_drvdata(ec, NULL);
>> >
>> >  	unregister_netdev(dev);
>> >  	free_netdev(dev);
>> > --
>> > 2.26.2
>> >
>>
>>
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]