From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68A3CC433DB for ; Wed, 17 Feb 2021 19:52:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2C68564E62 for ; Wed, 17 Feb 2021 19:52:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233399AbhBQTwA (ORCPT ); Wed, 17 Feb 2021 14:52:00 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:46288 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229707AbhBQTv7 (ORCPT ); Wed, 17 Feb 2021 14:51:59 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lCSqy-006xZ8-Fp; Wed, 17 Feb 2021 20:51:16 +0100 Date: Wed, 17 Feb 2021 20:51:16 +0100 From: Andrew Lunn To: "Wenzel, Marco" Cc: George McCollister , "netdev@vger.kernel.org" Subject: Re: HSR/PRP sequence counter issue with Cisco Redbox Message-ID: References: <69ec2fd1a9a048e8b3305a4bc36aad01@EXCH-SVR2013.eberle.local> <11291f9b05764307b660049e2290dd10@EXCH-SVR2013.eberle.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > From 8836f1df35a884327da37885ff3ad8bfc5eb933c Mon Sep 17 00:00:00 2001 > From: Marco Wenzel > Date: Wed, 17 Feb 2021 13:53:31 +0100 > Subject: [PATCH] net: hsr: add support for EntryForgetTime > > In IEC 62439-3 EntryForgetTime is defined with a value of 400 ms. When a > node does not send any frame within this time, the sequence number check > for can be ignored. This solves communication issues with Cisco IE 2000 > in Redbox mode. > > Signed-off-by: Marco Wenzel It would be nice to have a Fixes: tag here to indicate which commit introduced the problem. If it has been broken forever, reference the commit which added HSR. > diff --git a/net/hsr/hsr_framereg.h b/net/hsr/hsr_framereg.h > index 86b43f539f2c..7a120ce3e3db 100644 > --- a/net/hsr/hsr_framereg.h > +++ b/net/hsr/hsr_framereg.h > @@ -75,6 +75,7 @@ struct hsr_node { > enum hsr_port_type addr_B_port; > unsigned long time_in[HSR_PT_PORTS]; > bool time_in_stale[HSR_PT_PORTS]; > + unsigned long time_out[HSR_PT_PORTS]; It looks like the indentation is wrong here, and is using a mixture of tabs and spaces. Andrew