From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1716BC433E6 for ; Mon, 8 Feb 2021 09:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADEE464DAF for ; Mon, 8 Feb 2021 09:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232127AbhBHJw6 (ORCPT ); Mon, 8 Feb 2021 04:52:58 -0500 Received: from mail.kernel.org ([198.145.29.99]:54388 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231891AbhBHJtY (ORCPT ); Mon, 8 Feb 2021 04:49:24 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 0B44964E8F; Mon, 8 Feb 2021 09:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612777723; bh=PqjmFA18oNIVTBrl89NjKcEdBGtrMd1vwbKocOeM78c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lGo7Ue3wRD/4ZRaOJnnaunO2vEAOK1uTPQXdIJcc3H57MUtTjLAKzKksEEQLlBKZc 6ly33vXWzMyw0dU/QnMP09myxLW/SalgrCzg8TNVhdy8mnl+GW2EgvfSN+n+IfHVD4 DjuEDPAc+xaR6UuSpI2Djnq2n7H9Tg9vo3J4aAXs= Date: Mon, 8 Feb 2021 10:48:40 +0100 From: Greg KH To: "Schmid, Carsten" Cc: "netdev@vger.kernel.org" , "weiwan@google.com" , "idosch@idosch.org" , "jesse@mbuki-mvuki.org" , "kafai@fb.com" , "dsahern@gmail.com" , "davem@davemloft.net" Subject: Re: Where is this patch buried? Message-ID: References: <7953a4158fd14aabbcfbad8365231961@SVR-IES-MBX-03.mgc.mentorg.com> <1612776251858.30522@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1612776251858.30522@mentor.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 08, 2021 at 09:24:11AM +0000, Schmid, Carsten wrote: > >> Hi Greg, > >> > >> in kernel 4.14 i have seen a NULL pointer deref in > >> [65064.613465] RIP: 0010:ip_route_output_key_hash_rcu+0x755/0x850 > >> (i have a core dump and detailed analysis) > >> > >> That looks like this patch could have prevented it: > >> > >> https://www.spinics.net/lists/stable-commits/msg133055.html > >> > >> this one was queued for 4.14, but i can't find it in git tree? > >> Any idea who/what buried this one? > >> > >> In 4.19 it is present. > >> > >> Because our customer uses 4.14 (going to 4.14.212 in a few days) i kindly want to > >> ask why this patch hasn't entered 4.14. > > > > Because it breaks the build? Try it yourself and see what happens :) > > yep. rt_add_uncached_list is implemented _after_ the call :-( > > > > > I will gladly take a working backport if you can submit it. > > > Please find it attached - i needed to move rt_add_uncached_list before > the rt_cache_route, nothing else changed. > This is for 4.14 only, as other kernels do have this patch. > > I can't reproduce the crash at will, but at least i could compile and flash it on my target. > And the target comes up .. hopefully the testing in other/newer kernels > done by the developers of the patch is also valid for 4.14. Thanks, now queued up. greg k-h