From: Andrew Lunn <andrew@lunn.ch>
To: Jon Hunter <jonathanh@nvidia.com>
Cc: Saravana Kannan <saravanak@google.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Android Kernel Team <kernel-team@android.com>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Thierry Reding <treding@nvidia.com>
Subject: Re: phy_attach_direct()'s use of device_bind_driver()
Date: Thu, 11 Feb 2021 15:03:52 +0100 [thread overview]
Message-ID: <YCU5SCxePltSl2Oj@lunn.ch> (raw)
In-Reply-To: <5176f496-facb-d7b0-9f4e-a9e4b8974178@nvidia.com>
On Thu, Feb 11, 2021 at 10:21:03AM +0000, Jon Hunter wrote:
>
> On 10/02/2021 22:56, Andrew Lunn wrote:
> > On Wed, Feb 10, 2021 at 02:13:48PM -0800, Saravana Kannan wrote:
> >> Hi,
> >>
> >> This email was triggered by this other email[1].
> >
> > And it appears the Tegra194 Jetson Xavier uses the Marvell 88E1512
> > PHY. So ensure the Marvell driver is available, and it should get
> > probed in the usual way, the fallback driver will not be needed.
>
>
> Yes that is correct. Enabling the Marvell PHY does fix this indeed and
> so I can enable that as part of our testsuite. We were seeing the same
> warning on Tegra186 Jetson TX2 and enabling the BRCM PHY resolves that
> as well. I will ensure that these are enabled going forward.
Hi Jon
As an added bonus, you might of gained an additional HWMON temperature
sensor for the PHY, some PHY statistics, and maybe cable diagnostics.
Just by using the correct driver for the hardware.
Andrew
prev parent reply other threads:[~2021-02-11 14:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 22:13 phy_attach_direct()'s use of device_bind_driver() Saravana Kannan
2021-02-10 22:40 ` Heiner Kallweit
2021-02-10 22:52 ` Andrew Lunn
2021-02-10 23:29 ` Saravana Kannan
2021-02-11 7:31 ` Heiner Kallweit
2021-02-11 8:57 ` Saravana Kannan
2021-02-11 9:29 ` Heiner Kallweit
2021-02-11 13:57 ` Andrew Lunn
2021-02-12 3:42 ` Saravana Kannan
2021-02-12 14:04 ` Andrew Lunn
2021-02-10 22:56 ` Andrew Lunn
2021-02-11 10:21 ` Jon Hunter
2021-02-11 14:03 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCU5SCxePltSl2Oj@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=saravanak@google.com \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).