From: Jiri Olsa <jolsa@redhat.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: Stanislav Fomichev <sdf@google.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore
Date: Fri, 12 Feb 2021 22:04:50 +0100 [thread overview]
Message-ID: <YCbtcjR87iWWTVGx@krava> (raw)
In-Reply-To: <CAEf4BzZ60LNPpWL6z566hCCF1JkJC=-nZpqg7JQGaHp0rJYGhg@mail.gmail.com>
On Fri, Feb 12, 2021 at 11:48:46AM -0800, Andrii Nakryiko wrote:
> On Thu, Feb 11, 2021 at 5:07 PM Stanislav Fomichev <sdf@google.com> wrote:
> >
> > There is what I see after compiling the kernel:
>
> typo: This?
>
> >
> > # bpf-next...bpf-next/master
> > ?? tools/bpf/resolve_btfids/libbpf/
> >
> > Signed-off-by: Stanislav Fomichev <sdf@google.com>
> > ---
>
> Jiri,
>
> Is this
>
> Fixes: fc6b48f692f8 ("tools/resolve_btfids: Build libbpf and libsubcmd
> in separate directories")
yes
>
> ?
>
> Do we need similar stuff for libsubcmd (what's that, btw?)
as Stanislav said it's only .o files in there, so there's no need
it provides the parse_options functionality
jirka
>
> > tools/bpf/resolve_btfids/.gitignore | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/bpf/resolve_btfids/.gitignore b/tools/bpf/resolve_btfids/.gitignore
> > index 25f308c933cc..16913fffc985 100644
> > --- a/tools/bpf/resolve_btfids/.gitignore
> > +++ b/tools/bpf/resolve_btfids/.gitignore
> > @@ -1,2 +1,3 @@
> > /fixdep
> > /resolve_btfids
> > +/libbpf/
> > --
> > 2.30.0.478.g8a0d178c01-goog
> >
>
next prev parent reply other threads:[~2021-02-12 21:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 1:00 [PATCH bpf-next] tools/resolve_btfids: add /libbpf to .gitignore Stanislav Fomichev
2021-02-12 19:48 ` Andrii Nakryiko
2021-02-12 19:56 ` Stanislav Fomichev
2021-02-12 21:05 ` Jiri Olsa
2021-02-12 21:04 ` Jiri Olsa [this message]
2021-02-12 21:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCbtcjR87iWWTVGx@krava \
--to=jolsa@redhat.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).