From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux admin <linux@armlinux.org.uk>
Cc: Marek Behun <marek.behun@nic.cz>,
Nathan Rossi <nathan@nathanrossi.com>,
netdev@vger.kernel.org, Nathan Rossi <nathan.rossi@digi.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override
Date: Mon, 15 Feb 2021 16:11:37 +0100 [thread overview]
Message-ID: <YCqPKatln8CTkQhj@lunn.ch> (raw)
In-Reply-To: <20210215145757.GX1463@shell.armlinux.org.uk>
> If we can't switch between 1000base-X and 2500base-X, then we should
> not be calling phylink_helper_basex_speed() - and only one of those
> two capabilities should be set in the validation callback. I thought
> there were DSA switches where we could program the CMODE to switch
> between these two...
6390 family has a writable CMODE for ports 9 and 10, and you can
select various SERDES modes.
Nathan, what device are you using?
Andrew
next prev parent reply other threads:[~2021-02-15 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 6:15 [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override Nathan Rossi
2021-02-15 13:47 ` Marek Behun
2021-02-15 14:57 ` Russell King - ARM Linux admin
2021-02-15 15:11 ` Andrew Lunn [this message]
2021-02-15 15:16 ` Marek Behun
2021-02-15 15:29 ` Russell King - ARM Linux admin
2021-02-15 15:58 ` Marek Behun
2021-02-16 8:00 ` Nathan Rossi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCqPKatln8CTkQhj@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marek.behun@nic.cz \
--cc=nathan.rossi@digi.com \
--cc=nathan@nathanrossi.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).