From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE06EC433DB for ; Mon, 15 Feb 2021 15:13:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 90C3E64D7F for ; Mon, 15 Feb 2021 15:13:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230425AbhBOPNM (ORCPT ); Mon, 15 Feb 2021 10:13:12 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:42676 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230199AbhBOPM0 (ORCPT ); Mon, 15 Feb 2021 10:12:26 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lBfXF-006S6T-H8; Mon, 15 Feb 2021 16:11:37 +0100 Date: Mon, 15 Feb 2021 16:11:37 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Marek Behun , Nathan Rossi , netdev@vger.kernel.org, Nathan Rossi , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Jakub Kicinski Subject: Re: [PATCH] net: dsa: mv88e6xxx: prevent 2500BASEX mode override Message-ID: References: <20210215061559.1187396-1-nathan@nathanrossi.com> <20210215144756.76846c9b@nic.cz> <20210215145757.GX1463@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210215145757.GX1463@shell.armlinux.org.uk> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > If we can't switch between 1000base-X and 2500base-X, then we should > not be calling phylink_helper_basex_speed() - and only one of those > two capabilities should be set in the validation callback. I thought > there were DSA switches where we could program the CMODE to switch > between these two... 6390 family has a writable CMODE for ports 9 and 10, and you can select various SERDES modes. Nathan, what device are you using? Andrew