From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Du Cheng <ducheng2@gmail.com>
Cc: Manish Chopra <manishc@marvell.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] fix coding style in driver/staging/qlge/qlge_main.c
Date: Tue, 16 Feb 2021 08:26:43 +0100 [thread overview]
Message-ID: <YCtzs/wtXqFxUTok@kroah.com> (raw)
In-Reply-To: <20210216071849.174077-1-ducheng2@gmail.com>
On Tue, Feb 16, 2021 at 03:18:49PM +0800, Du Cheng wrote:
> align * in block comments on each line
>
> Signed-off-by: Du Cheng <ducheng2@gmail.com>
> ---
> drivers/staging/qlge/qlge_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> index 5516be3af898..bfd7217f3953 100644
> --- a/drivers/staging/qlge/qlge_main.c
> +++ b/drivers/staging/qlge/qlge_main.c
> @@ -3816,7 +3816,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev)
> qlge_tx_ring_clean(qdev);
>
> /* Call netif_napi_del() from common point.
> - */
> + */
Just put it on the previous line please.
Also use scripts/get_maintainer.pl to find the proper lists to send this
to in the future, you forgot the staging mailing list :(
thanks,
greg k-h
prev parent reply other threads:[~2021-02-16 7:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 7:18 [PATCH] fix coding style in driver/staging/qlge/qlge_main.c Du Cheng
2021-02-16 7:26 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCtzs/wtXqFxUTok@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=ducheng2@gmail.com \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).