From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F92C433E0 for ; Tue, 16 Feb 2021 13:07:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F13964D99 for ; Tue, 16 Feb 2021 13:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229806AbhBPNHN (ORCPT ); Tue, 16 Feb 2021 08:07:13 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:43990 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229864AbhBPNHM (ORCPT ); Tue, 16 Feb 2021 08:07:12 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lC03g-006h0z-IM; Tue, 16 Feb 2021 14:06:28 +0100 Date: Tue, 16 Feb 2021 14:06:28 +0100 From: Andrew Lunn To: Nathan Rossi Cc: netdev@vger.kernel.org, Nathan Rossi , Heiner Kallweit , "David S. Miller" , Jakub Kicinski Subject: Re: [PATCH] of: of_mdio: Handle properties for non-phy mdio devices Message-ID: References: <20210215070218.1188903-1-nathan@nathanrossi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210215070218.1188903-1-nathan@nathanrossi.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 15, 2021 at 07:02:18AM +0000, Nathan Rossi wrote: > From: Nathan Rossi > > The documentation for MDIO bindings describes the "broken-turn-around", > "reset-assert-us", and "reset-deassert-us" properties such that any MDIO > device can define them. Other MDIO devices may require these properties > in order to correctly function on the MDIO bus. > > Enable the parsing and configuration associated with these properties by > moving the associated OF parsing to a common function > of_mdiobus_child_parse and use it to apply these properties for both > PHYs and other MDIO devices. Hi Nathan What device are you using this with? The Marvell Switch driver does its own GPIO reset handling. It has a better idea when a hardware reset should be applied than what the phylib core has. It will also poll the EEPROM busy bit after a reset. How long a pause you need after the reset depends on how full the EEPROM is. And i've never had problems with broken-turn-around with Marvell switches. Given the complexity of an Ethernet switch, it is probably better if it handles its own reset. Andrew