From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62EE6C433E0 for ; Wed, 17 Feb 2021 03:20:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 193CB64DFF for ; Wed, 17 Feb 2021 03:20:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230454AbhBQDUj (ORCPT ); Tue, 16 Feb 2021 22:20:39 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:45204 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229796AbhBQDUi (ORCPT ); Tue, 16 Feb 2021 22:20:38 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lCDNa-006nxv-L5; Wed, 17 Feb 2021 04:19:54 +0100 Date: Wed, 17 Feb 2021 04:19:54 +0100 From: Andrew Lunn To: Nathan Rossi Cc: Florian Fainelli , netdev@vger.kernel.org, Nathan Rossi , Heiner Kallweit , "David S. Miller" , Jakub Kicinski Subject: Re: [PATCH] of: of_mdio: Handle properties for non-phy mdio devices Message-ID: References: <20210215070218.1188903-1-nathan@nathanrossi.com> <55c94cf4-f660-f0f5-fb04-f51f4d175f53@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > > The patch does make sense though, Broadcom 53125 switches have a broken > > turn around and are mdio_device instances, the broken behavior may not > > show up with all MDIO controllers used to interface though. For the > > Yes the reason we needed this change was to enable broken turn around, > specifically with a Marvell 88E6390. Ah, odd. I've never had problems with the 6390, either connected to a Freecale FEC, or the Linux bit banging MDIO bus. What are you using for an MDIO bus controller? Did it already support broken turn around, or did you need to add it? Andrew