From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA688C433DB for ; Tue, 23 Feb 2021 15:19:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6F20464E60 for ; Tue, 23 Feb 2021 15:19:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233084AbhBWPTV convert rfc822-to-8bit (ORCPT ); Tue, 23 Feb 2021 10:19:21 -0500 Received: from us-smtp-delivery-44.mimecast.com ([205.139.111.44]:59495 "EHLO us-smtp-delivery-44.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231919AbhBWPTQ (ORCPT ); Tue, 23 Feb 2021 10:19:16 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-nW7OIwhVPt6Wbq1WRAL8tA-1; Tue, 23 Feb 2021 10:18:20 -0500 X-MC-Unique: nW7OIwhVPt6Wbq1WRAL8tA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4283D100A262; Tue, 23 Feb 2021 15:12:38 +0000 (UTC) Received: from hog (ovpn-112-129.ams2.redhat.com [10.36.112.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6352B1899A; Tue, 23 Feb 2021 15:12:36 +0000 (UTC) Date: Tue, 23 Feb 2021 16:12:34 +0100 From: Sabrina Dubroca To: Eyal Birger Cc: steffen.klassert@secunet.com, herbert@gondor.apana.org.au, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH ipsec,v2] xfrm: interface: fix ipv4 pmtu check to honor ip header df Message-ID: References: <20210219172127.2223831-1-eyal.birger@gmail.com> <20210220130115.2914135-1-eyal.birger@gmail.com> MIME-Version: 1.0 In-Reply-To: <20210220130115.2914135-1-eyal.birger@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=sd@queasysnail.net X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: queasysnail.net Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2021-02-20, 15:01:15 +0200, Eyal Birger wrote: > Frag needed should only be sent if the header enables DF. > > This fix allows packets larger than MTU to pass the xfrm interface > and be fragmented after encapsulation, aligning behavior with > non-interface xfrm. > > Fixes: f203b76d7809 ("xfrm: Add virtual xfrm interfaces") > Signed-off-by: Eyal Birger > > ----- > > v2: better align coding with ip_vti LGTM. We also need to do the same thing in ip_vti and ip6_vti. Do you want to take care of it, or should I? Either way, for this patch: Reviewed-by: Sabrina Dubroca -- Sabrina