From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB61BC433E6 for ; Wed, 24 Feb 2021 13:11:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9677A64EF5 for ; Wed, 24 Feb 2021 13:11:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234468AbhBXNJo (ORCPT ); Wed, 24 Feb 2021 08:09:44 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:55778 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235428AbhBXNCk (ORCPT ); Wed, 24 Feb 2021 08:02:40 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lEtnO-008E6E-IC; Wed, 24 Feb 2021 14:01:38 +0100 Date: Wed, 24 Feb 2021 14:01:38 +0100 From: Andrew Lunn To: Jakub Kicinski Cc: Joakim Zhang , "peppe.cavallaro@st.com" , "alexandre.torgue@st.com" , "joabreu@synopsys.com" , "davem@davemloft.net" , "netdev@vger.kernel.org" , dl-linux-imx Subject: Re: [PATCH V1 net-next 0/3] net: stmmac: implement clocks Message-ID: References: <20210223104818.1933-1-qiangqing.zhang@nxp.com> <20210223084503.34ae93f7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210223175441.2a1b86f1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223175441.2a1b86f1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Understood. Please double check ethtool callbacks work fine. People > often forget about those when disabling clocks in .close. The MDIO bus can also be used at any time, not just when the interface is open. For example the MAC could be connected to an Ethernet switch, which is managed by the MDIO bus. Or some PHYs have a temperature sensor which is registered with HWMON when the PHY is probed. You said you copied the FEC driver. Take a look at that, it was initially broken in this way, and i needed to extend it when i got a board with an Ethernet switch attached to the FEC. Andrew