From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2C6FC433E0 for ; Thu, 25 Feb 2021 01:21:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5E32464EF1 for ; Thu, 25 Feb 2021 01:21:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234319AbhBYBVD (ORCPT ); Wed, 24 Feb 2021 20:21:03 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:56826 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233826AbhBYBVB (ORCPT ); Wed, 24 Feb 2021 20:21:01 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lF5KF-008KWl-0H; Thu, 25 Feb 2021 02:20:19 +0100 Date: Thu, 25 Feb 2021 02:20:18 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: netdev@vger.kernel.org, Florian Fainelli , Vivien Didelot , Jiri Pirko , Ido Schimmel , DENG Qingfang , Tobias Waldekranz , George McCollister , Horatiu Vultur , Kurt Kanzenbach Subject: Re: [RFC PATCH net-next 07/12] Documentation: networking: dsa: mention integration with devlink Message-ID: References: <20210221213355.1241450-1-olteanv@gmail.com> <20210221213355.1241450-8-olteanv@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210221213355.1241450-8-olteanv@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Feb 21, 2021 at 11:33:50PM +0200, Vladimir Oltean wrote: > From: Vladimir Oltean > > Add a short summary of the devlink features supported by the DSA core. > > Signed-off-by: Vladimir Oltean > --- > Documentation/networking/dsa/dsa.rst | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/Documentation/networking/dsa/dsa.rst b/Documentation/networking/dsa/dsa.rst > index 3c6560a43ae0..463b48714fe9 100644 > --- a/Documentation/networking/dsa/dsa.rst > +++ b/Documentation/networking/dsa/dsa.rst > @@ -394,6 +394,7 @@ DSA currently leverages the following subsystems: > - MDIO/PHY library: ``drivers/net/phy/phy.c``, ``mdio_bus.c`` > - Switchdev:``net/switchdev/*`` > - Device Tree for various of_* functions > +- Devlink: ``net/core/devlink.c`` > > MDIO/PHY library > ---------------- > @@ -433,6 +434,32 @@ more specifically with its VLAN filtering portion when configuring VLANs on top > of per-port slave network devices. As of today, the only SWITCHDEV objects > supported by DSA are the FDB and VLAN objects. > > +Devlink > +------- > + > +DSA registers one devlink device per each physical switch in the fabric. "per each" sounds wrong to my ears. per on its own is better. > +For each devlink device, every physical port (i.e. user ports, CPU ports, DSA > +links and unused ports) is exposed as a devlink port. I would probably use "or", instead of "and". > + > +DSA drivers can make use of the following devlink features: > +- Regions: debugging feature which allows user space to dump driver-defined > + areas of hardware information in a low-level, binary format. Both global > + regions as well as per-port regions are supported. Since address tables and > + VLAN tables are only inspectable by core iproute2 tools (ip-link, bridge) on > + user ports, devlink regions can be created for dumping these tables on the > + non-user ports too. You might also add that additional details which don't fit the iproute2 model can be included in regions dumps, since the format is not restricted. Reviewed-by: Andrew Lunn Andrew